From: Seunghun Lee <shiin.lee@samsung.com>
Date: Wed, 8 Jun 2022 07:25:42 +0000 (+0900)
Subject: keyrouter: Properly test for allocation failure
X-Git-Tag: accepted/tizen/unified/20220720.034120~34
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5af8f0152be3f2aaf5543e8c3098d1e6014c2638;p=platform%2Fcore%2Fuifw%2Flibds-tizen.git

keyrouter: Properly test for allocation failure

Instead of testing the return of the function just called, it was
testing something already checked earlier.

Change-Id: Ibaa7884360afaa195d843bc90588e3af85caf0d0
---

diff --git a/src/keyrouter/keyrouter_grab.c b/src/keyrouter/keyrouter_grab.c
index 5009985..6af0c85 100644
--- a/src/keyrouter/keyrouter_grab.c
+++ b/src/keyrouter/keyrouter_grab.c
@@ -300,7 +300,7 @@ keyrouter_grab_create(void)
 
     /* FIXME: Who defined max keycode? */
     keyrouter_grab->hard_keys = calloc(KEYROUTER_MAX_KEYS, sizeof(struct ds_tizen_keyrouter_grabbed));
-    if (keyrouter_grab == NULL) {
+    if (keyrouter_grab->hard_keys == NULL) {
         ds_err("Failed to allocate memory.");
         free(keyrouter_grab);
         return NULL;