From: Panu Matilainen <pmatilai@redhat.com>
Date: Sat, 28 Jan 2012 13:17:02 +0000 (+0200)
Subject: Don't assume rpmteNew() always succeeds, part III
X-Git-Tag: tznext/4.11.0.1.tizen20130304~679
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5aeebe8d695471835a4984cb0e7e4f4c8d206d70;p=tools%2Flibrpm-tizen.git

Don't assume rpmteNew() always succeeds, part III

- Return error from verifyscript if rpmteNew() fails. This can't
  currently happen but handling this error makes it possible to
  do sanity checks on the header contents, such as file list integrity etc.
  Unlikely to occur for installed packages, but verify can be run
  on non-installed packages as well, where failure is more of a possibility.
---

diff --git a/lib/verify.c b/lib/verify.c
index 48f749c..21289d1 100644
--- a/lib/verify.c
+++ b/lib/verify.c
@@ -263,12 +263,17 @@ static int rpmVerifyScript(rpmts ts, Header h)
     if (headerIsEntry(h, RPMTAG_VERIFYSCRIPT)) {
 	/* fake up a erasure transaction element */
 	rpmte p = rpmteNew(ts, h, TR_REMOVED, NULL, NULL);
-	rpmteSetHeader(p, h);
 
-	rc = (rpmpsmRun(ts, p, PKG_VERIFY) != RPMRC_OK);
+	if (p != NULL) {
+	    rpmteSetHeader(p, h);
 
-	/* clean up our fake transaction bits */
-	rpmteFree(p);
+	    rc = (rpmpsmRun(ts, p, PKG_VERIFY) != RPMRC_OK);
+
+	    /* clean up our fake transaction bits */
+	    rpmteFree(p);
+	} else {
+	    rc = RPMRC_FAIL;
+	}
     }
 
     return rc;