From: Ross Lagerwall Date: Tue, 9 Jan 2018 12:10:21 +0000 (+0000) Subject: xen/gntdev: Fix off-by-one error when unmapping with holes X-Git-Tag: v4.14.24~16 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5aee2c142e3d7803cb8535fb92806b1f239390bc;p=platform%2Fkernel%2Flinux-rpi.git xen/gntdev: Fix off-by-one error when unmapping with holes [ Upstream commit 951a010233625b77cde3430b4b8785a9a22968d1 ] If the requested range has a hole, the calculation of the number of pages to unmap is off by one. Fix it. Signed-off-by: Ross Lagerwall Reviewed-by: Boris Ostrovsky Signed-off-by: Boris Ostrovsky Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 57efbd3..d3391a1 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -380,10 +380,8 @@ static int unmap_grant_pages(struct grant_map *map, int offset, int pages) } range = 0; while (range < pages) { - if (map->unmap_ops[offset+range].handle == -1) { - range--; + if (map->unmap_ops[offset+range].handle == -1) break; - } range++; } err = __unmap_grant_pages(map, offset, range);