From: Ofir Bitton Date: Tue, 11 Aug 2020 05:11:49 +0000 (+0300) Subject: habanalabs: correctly report inbound pci region cfg error X-Git-Tag: v5.10.7~1762^2^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5aba368893c0d9e275f4b823e053fd16155f63b9;p=platform%2Fkernel%2Flinux-rpi.git habanalabs: correctly report inbound pci region cfg error During inbound iATU configuration we can get errors while configuring PCI registers, there is a certain scenario in which these errors are not reflected and driver is loaded with wrong configuration. Signed-off-by: Ofir Bitton Signed-off-by: Oded Gabbay --- diff --git a/drivers/misc/habanalabs/common/pci.c b/drivers/misc/habanalabs/common/pci.c index b8184cb..2770f03 100644 --- a/drivers/misc/habanalabs/common/pci.c +++ b/drivers/misc/habanalabs/common/pci.c @@ -227,7 +227,7 @@ int hl_pci_set_inbound_region(struct hl_device *hdev, u8 region, } /* Point to the specified address */ - rc = hl_pci_iatu_write(hdev, offset + 0x14, + rc |= hl_pci_iatu_write(hdev, offset + 0x14, lower_32_bits(pci_region->addr)); rc |= hl_pci_iatu_write(hdev, offset + 0x18, upper_32_bits(pci_region->addr));