From: Maxime Chevallier Date: Tue, 10 Oct 2017 08:43:17 +0000 (+0200) Subject: spi: a3700: Return correct value on timeout detection X-Git-Tag: v4.14-rc7~23^2^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5a866ec0014b2baa4ecbb1eaa19c835482829d08;p=platform%2Fkernel%2Flinux-rpi.git spi: a3700: Return correct value on timeout detection When waiting for transfer completion, a3700_spi_wait_completion returns a boolean indicating if a timeout occurred. The function was returning 'true' everytime, failing to detect any timeout. This patch makes it return 'false' when a timeout is reached. Signed-off-by: Maxime Chevallier Signed-off-by: Mark Brown Cc: stable@vger.kernel.org --- diff --git a/drivers/spi/spi-armada-3700.c b/drivers/spi/spi-armada-3700.c index 9172cb2..568e1c6 100644 --- a/drivers/spi/spi-armada-3700.c +++ b/drivers/spi/spi-armada-3700.c @@ -387,7 +387,8 @@ static bool a3700_spi_wait_completion(struct spi_device *spi) spireg_write(a3700_spi, A3700_SPI_INT_MASK_REG, 0); - return true; + /* Timeout was reached */ + return false; } static bool a3700_spi_transfer_wait(struct spi_device *spi,