From: Sangchul Lee <sc11.lee@samsung.com>
Date: Wed, 20 Apr 2022 15:38:37 +0000 (+0900)
Subject: webrtcbin: Avoid access of freed memory
X-Git-Tag: accepted/tizen/unified/20220920.160548^0
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5a21d05ad34f06b4aa9c0fbbb11388ddcf96a725;p=platform%2Fupstream%2Fgstreamer.git

webrtcbin: Avoid access of freed memory

Change-Id: I3489f2f718bdcd298ffc90c62a7352544293a70c
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2256>
---

diff --git a/subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcbin.c b/subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcbin.c
index 6013788..45bce86 100644
--- a/subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcbin.c
+++ b/subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcbin.c
@@ -1874,9 +1874,6 @@ _find_codec_preferences (GstWebRTCBin * webrtc,
 
       caps = _query_pad_caps (webrtc, rtp_trans, pad, filter, error);
     }
-#ifndef TIZEN_FEATURE_WEBRTC_MODIFICATION
-    gst_object_unref (pad);
-#endif
 
     if (*error)
       goto out;
@@ -1932,10 +1929,8 @@ _find_codec_preferences (GstWebRTCBin * webrtc,
 
 out:
 
-#ifdef TIZEN_FEATURE_WEBRTC_MODIFICATION
   if (pad)
     gst_object_unref (pad);
-#endif
   if (codec_preferences)
     gst_caps_unref (codec_preferences);