From: Dan Carpenter Date: Wed, 10 Oct 2018 19:30:17 +0000 (-0700) Subject: ipv4: frags: precedence bug in ip_expire() X-Git-Tag: v4.9.134~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5a0f340f5ad6a6cc6518f212802f95b669e8fe27;p=platform%2Fkernel%2Flinux-amlogic.git ipv4: frags: precedence bug in ip_expire() (commit 70837ffe3085c9a91488b52ca13ac84424da1042 upstream) We accidentally removed the parentheses here, but they are required because '!' has higher precedence than '&'. Fixes: fa0f527358bd ("ip: use rb trees for IP frag queue.") Signed-off-by: Dan Carpenter Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- diff --git a/net/ipv4/ip_fragment.c b/net/ipv4/ip_fragment.c index 09565b14ba6b..cc8c6ac84d08 100644 --- a/net/ipv4/ip_fragment.c +++ b/net/ipv4/ip_fragment.c @@ -203,7 +203,7 @@ static void ip_expire(unsigned long arg) __IP_INC_STATS(net, IPSTATS_MIB_REASMFAILS); __IP_INC_STATS(net, IPSTATS_MIB_REASMTIMEOUT); - if (!qp->q.flags & INET_FRAG_FIRST_IN) + if (!(qp->q.flags & INET_FRAG_FIRST_IN)) goto out; /* sk_buff::dev and sk_buff::rbnode are unionized. So we