From: Mathieu Duponchelle <mathieu@centricular.com>
Date: Thu, 30 May 2019 16:43:14 +0000 (+0200)
Subject: compositor: remove invalid test
X-Git-Tag: 1.19.3~511^2~1061
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=59dd2af6d66333815d62584e5a20474b46525cf9;p=platform%2Fupstream%2Fgstreamer.git

compositor: remove invalid test

With https://gitlab.freedesktop.org/gstreamer/gstreamer/merge_requests/159,
a single flush start on an aggregator sinkpad will start the flushing
process if the aggregator isn't already flushing.

The behaviour that this test was checking for is thus no longer correct
---

diff --git a/tests/check/elements/compositor.c b/tests/check/elements/compositor.c
index 6b7a4e6..3aebf01 100644
--- a/tests/check/elements/compositor.c
+++ b/tests/check/elements/compositor.c
@@ -1383,47 +1383,6 @@ GST_START_TEST (test_loop)
 
 GST_END_TEST;
 
-GST_START_TEST (test_flush_start_flush_stop)
-{
-  GstPadTemplate *sink_template;
-  GstPad *sinkpad1, *sinkpad2, *compositor_src;
-  GstElement *compositor;
-
-  GST_INFO ("preparing test");
-
-  /* build pipeline */
-  compositor = gst_element_factory_make ("compositor", "compositor");
-
-  sink_template =
-      gst_element_class_get_pad_template (GST_ELEMENT_GET_CLASS (compositor),
-      "sink_%u");
-  fail_unless (GST_IS_PAD_TEMPLATE (sink_template));
-  sinkpad1 = gst_element_request_pad (compositor, sink_template, NULL, NULL);
-  sinkpad2 = gst_element_request_pad (compositor, sink_template, NULL, NULL);
-  gst_object_unref (sinkpad2);
-
-  gst_element_set_state (compositor, GST_STATE_PLAYING);
-  fail_unless (gst_element_get_state (compositor, NULL, NULL,
-          GST_CLOCK_TIME_NONE) == GST_STATE_CHANGE_SUCCESS);
-
-  compositor_src = gst_element_get_static_pad (compositor, "src");
-  fail_if (GST_PAD_IS_FLUSHING (compositor_src));
-  gst_pad_send_event (sinkpad1, gst_event_new_flush_start ());
-  fail_if (GST_PAD_IS_FLUSHING (compositor_src));
-  fail_unless (GST_PAD_IS_FLUSHING (sinkpad1));
-  gst_pad_send_event (sinkpad1, gst_event_new_flush_stop (TRUE));
-  fail_if (GST_PAD_IS_FLUSHING (compositor_src));
-  fail_if (GST_PAD_IS_FLUSHING (sinkpad1));
-  gst_object_unref (compositor_src);
-
-  /* cleanup */
-  gst_element_set_state (compositor, GST_STATE_NULL);
-  gst_object_unref (sinkpad1);
-  gst_object_unref (compositor);
-}
-
-GST_END_TEST;
-
 GST_START_TEST (test_segment_base_handling)
 {
   GstElement *pipeline, *sink, *mix, *src1, *src2;
@@ -2094,7 +2053,6 @@ compositor_suite (void)
   tcase_add_test (tc_chain, test_duration_is_max);
   tcase_add_test (tc_chain, test_duration_unknown_overrides);
   tcase_add_test (tc_chain, test_loop);
-  tcase_add_test (tc_chain, test_flush_start_flush_stop);
   tcase_add_test (tc_chain, test_segment_base_handling);
   tcase_add_test (tc_chain, test_obscured_skipped);
   tcase_add_test (tc_chain, test_repeat_after_eos);