From: Chun-wei Fan Date: Wed, 20 Jun 2012 02:19:14 +0000 (+0800) Subject: msvc_recommended_pragmas.h: Re-enable C4819 warnings X-Git-Tag: 2.33.3~32 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=599d1a430e787f7cda929b8b0188a01f39453e66;p=platform%2Fupstream%2Fglib.git msvc_recommended_pragmas.h: Re-enable C4819 warnings Apparently the C4819 warnings appear due to a bug on Visual C++ on DBCS locales, so re-enable this. Add a note in the Visual C++ Readme.txt's regarding this. --- diff --git a/build/win32/vs10/README.txt b/build/win32/vs10/README.txt index 69da5f4e1..b5e092f07 100644 --- a/build/win32/vs10/README.txt +++ b/build/win32/vs10/README.txt @@ -73,5 +73,12 @@ built DLLs go into \vs10\\bin, built LIBs into project files higher in the stack are supposed to look for them, not from a specific GLib source tree. +Note: If you see C4819 warnings and you are compiling GLib on a DBCS +(Chinese/Korean/Japanese) version of Windows, you may need to switch +to an English locale in Control Panel->Region and Languages->System-> +Change System Locale, reboot and rebuild to ensure GLib, Pango, GDK-Pixbuf, +ATK and GTK+ is built correctly. This is due to a bug in Visual C++ running +on DBCS locales. + --Tor Lillqvist --Updated by Chun-wei Fan diff --git a/build/win32/vs9/README.txt b/build/win32/vs9/README.txt index d760ce8ad..59e77b28a 100644 --- a/build/win32/vs9/README.txt +++ b/build/win32/vs9/README.txt @@ -73,5 +73,12 @@ built DLLs go into \vs9\\bin, built LIBs into project files higher in the stack are supposed to look for them, not from a specific GLib source tree. +Note: If you see C4819 warnings and you are compiling GLib on a DBCS +(Chinese/Korean/Japanese) version of Windows, you may need to switch +to an English locale in Control Panel->Region and Languages->System-> +Change System Locale, reboot and rebuild to ensure GLib, Pango, GDK-Pixbuf, +ATK and GTK+ is built correctly. This is due to a bug in Visual C++ running +on DBCS locales. + --Tor Lillqvist --Updated by Chun-wei Fan diff --git a/msvc_recommended_pragmas.h b/msvc_recommended_pragmas.h index ff4028e2d..f78f9a1ca 100644 --- a/msvc_recommended_pragmas.h +++ b/msvc_recommended_pragmas.h @@ -27,9 +27,6 @@ #pragma warning(disable:4244) /* No possible loss of data warnings */ #pragma warning(disable:4305) /* No truncation from int to char warnings */ -/* The file contains a character that cannot be represented in the current code page */ -#pragma warning(disable:4819) - /* work around Microsoft's premature attempt to deprecate the C-Library */ #define _CRT_SECURE_NO_WARNINGS #define _CRT_NONSTDC_NO_WARNINGS