From: Simon Pilgrim Date: Wed, 8 Jan 2020 16:41:41 +0000 (+0000) Subject: Fix "pointer is null" static analyzer warning. NFCI. X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5936717fa6537812257990143e2384bb78486ef9;p=platform%2Fupstream%2Fllvm.git Fix "pointer is null" static analyzer warning. NFCI. Use castAs<> instead of getAs<> since we know that the pointer will be valid (and is dereferenced immediately below). --- diff --git a/clang/lib/CodeGen/CGOpenCLRuntime.cpp b/clang/lib/CodeGen/CGOpenCLRuntime.cpp index 191a95c..dbe3752 100644 --- a/clang/lib/CodeGen/CGOpenCLRuntime.cpp +++ b/clang/lib/CodeGen/CGOpenCLRuntime.cpp @@ -96,7 +96,7 @@ llvm::PointerType *CGOpenCLRuntime::getSamplerType(const Type *T) { } llvm::Value *CGOpenCLRuntime::getPipeElemSize(const Expr *PipeArg) { - const PipeType *PipeTy = PipeArg->getType()->getAs(); + const PipeType *PipeTy = PipeArg->getType()->castAs(); // The type of the last (implicit) argument to be passed. llvm::Type *Int32Ty = llvm::IntegerType::getInt32Ty(CGM.getLLVMContext()); unsigned TypeSize = CGM.getContext() @@ -106,7 +106,7 @@ llvm::Value *CGOpenCLRuntime::getPipeElemSize(const Expr *PipeArg) { } llvm::Value *CGOpenCLRuntime::getPipeElemAlign(const Expr *PipeArg) { - const PipeType *PipeTy = PipeArg->getType()->getAs(); + const PipeType *PipeTy = PipeArg->getType()->castAs(); // The type of the last (implicit) argument to be passed. llvm::Type *Int32Ty = llvm::IntegerType::getInt32Ty(CGM.getLLVMContext()); unsigned TypeSize = CGM.getContext()