From: Ben Skeggs Date: Mon, 26 Mar 2012 07:18:40 +0000 (+1000) Subject: drm/nouveau/i2c: fix thinko/regression on really old chipsets X-Git-Tag: upstream/snapshot3+hdmi~7825^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=59365671464539dc695bbf4d4bf37aabfd8604f2;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git drm/nouveau/i2c: fix thinko/regression on really old chipsets Fixes i2c on my TNT2. Signed-off-by: Ben Skeggs Signed-off-by: Dave Airlie --- diff --git a/drivers/gpu/drm/nouveau/nouveau_i2c.c b/drivers/gpu/drm/nouveau/nouveau_i2c.c index 8f4f914..e2be95a 100644 --- a/drivers/gpu/drm/nouveau/nouveau_i2c.c +++ b/drivers/gpu/drm/nouveau/nouveau_i2c.c @@ -315,8 +315,8 @@ nouveau_i2c_init(struct drm_device *dev) struct drm_nouveau_private *dev_priv = dev->dev_private; struct nvbios *bios = &dev_priv->vbios; struct nouveau_i2c_chan *port; + u8 version = 0x00, entries, recordlen; u8 *i2c, *entry, legacy[2][4] = {}; - u8 version, entries, recordlen; int ret, i; INIT_LIST_HEAD(&dev_priv->i2c_ports); @@ -346,12 +346,12 @@ nouveau_i2c_init(struct drm_device *dev) if (i2c[7]) legacy[1][1] = i2c[7]; } - if (i2c && version >= 0x30) { + if (version >= 0x30) { entry = i2c[1] + i2c; entries = i2c[2]; recordlen = i2c[3]; } else - if (i2c) { + if (version) { entry = i2c; entries = 16; recordlen = 4;