From: Nishka Dasgupta Date: Sun, 4 Aug 2019 16:34:44 +0000 (+0530) Subject: clk: versatile: Add of_node_put() in cm_osc_setup() X-Git-Tag: v5.15~5472^2~5^3~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5911dba556cf41a14907ed04b5636cf852b17933;p=platform%2Fkernel%2Flinux-starfive.git clk: versatile: Add of_node_put() in cm_osc_setup() In function cm_osc_setup, variable parent takes the value returned by of_get_parent, which gets a node but does not put it. If parent is not put before it goes out of scope, it may cause a memory leak. Hence put parent before the function terminates. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta Link: https://lkml.kernel.org/r/20190804163445.6862-1-nishkadg.linux@gmail.com Reviewed-by: Linus Walleij Signed-off-by: Stephen Boyd --- diff --git a/drivers/clk/versatile/clk-versatile.c b/drivers/clk/versatile/clk-versatile.c index 90bb0b0..fd54d5c 100644 --- a/drivers/clk/versatile/clk-versatile.c +++ b/drivers/clk/versatile/clk-versatile.c @@ -70,6 +70,7 @@ static void __init cm_osc_setup(struct device_node *np, return; } cm_base = of_iomap(parent, 0); + of_node_put(parent); if (!cm_base) { pr_err("could not remap core module base\n"); return;