From: Peter Senna Tschudin Date: Mon, 24 Sep 2012 09:11:03 +0000 (-0300) Subject: [media] drivers/media/platform/soc_camera/mx2_camera.c: fix error return code X-Git-Tag: upstream/snapshot3+hdmi~4891^2~944 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=58dec65d714f9f2872fdfe8f6a1f36027431de95;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git [media] drivers/media/platform/soc_camera/mx2_camera.c: fix error return code Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // [mchehab@redhat.com: Second hunk removed, as it doesn't apply anymore, due to a merge conflict] Signed-off-by: Peter Senna Tschudin Signed-off-by: Guennadi Liakhovetski Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/soc_camera/mx2_camera.c b/drivers/media/platform/soc_camera/mx2_camera.c index 8d25871..9fd9d1c 100644 --- a/drivers/media/platform/soc_camera/mx2_camera.c +++ b/drivers/media/platform/soc_camera/mx2_camera.c @@ -1655,6 +1655,7 @@ static int __devinit mx27_camera_emma_init(struct platform_device *pdev) irq_emma = platform_get_irq(pdev, 1); if (!res_emma || !irq_emma) { dev_err(pcdev->dev, "no EMMA resources\n"); + err = -ENODEV; goto out; }