From: Hanno Boeck <hanno@hboeck.de>
Date: Sat, 27 Feb 2016 11:16:00 +0000 (+0000)
Subject: NULL-terminate PyMethodDef array
X-Git-Tag: 1.19.3~485^2~144
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=58c324e0ccc21498a7e29d82dc00ed008050d26c;p=platform%2Fupstream%2Fgstreamer.git

NULL-terminate PyMethodDef array

PyMethodDef arrays are supposed to end with an entry full of NULL/0 values.
This is missing in gst-python in the file gstmodule.c.

This causes out of bounds memory reads which can be seen / tested by compiling
gst-python with address sanitizer (-fsanitize=address in CFLAGS/LDFLAGS).

https://bugzilla.gnome.org/show_bug.cgi?id=762766
---

diff --git a/gi/overrides/gstmodule.c b/gi/overrides/gstmodule.c
index e426165..79311a3 100644
--- a/gi/overrides/gstmodule.c
+++ b/gi/overrides/gstmodule.c
@@ -368,7 +368,8 @@ static PyMethodDef _gi_gst_functions[] = {
   {"fixme", (PyCFunction) _wrap_gst_fixme, METH_VARARGS,
       NULL},
   {"memdump", (PyCFunction) _wrap_gst_memdump, METH_VARARGS,
-      NULL}
+      NULL},
+  {NULL, NULL, 0, NULL}
 };
 
 PYGLIB_MODULE_START (_gi_gst, "_gi_gst")