From: Sebastian Hesselbarth Date: Fri, 13 Dec 2013 09:20:25 +0000 (+0100) Subject: net: mv643xx_eth: properly start/stop phy device X-Git-Tag: accepted/tizen/common/20141203.182822~719^2~483^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=58911151aa0afc922f081d1516455c8833fce6b9;p=platform%2Fkernel%2Flinux-arm64.git net: mv643xx_eth: properly start/stop phy device When using phydev, it should be phy_start/phy_stop'ed properly. This driver doesn't do that, so add the corresponding calls to port_start/ stop respectively. Signed-off-by: Sebastian Hesselbarth Acked-by: Mugunthan V N Reviewed-by: Florian Fainelli Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c index b3d9327..a2565ce 100644 --- a/drivers/net/ethernet/marvell/mv643xx_eth.c +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c @@ -2080,6 +2080,7 @@ static void port_start(struct mv643xx_eth_private *mp) mv643xx_eth_get_settings(mp->dev, &cmd); phy_init_hw(mp->phy); mv643xx_eth_set_settings(mp->dev, &cmd); + phy_start(mp->phy); } /* @@ -2275,7 +2276,8 @@ static int mv643xx_eth_stop(struct net_device *dev) del_timer_sync(&mp->rx_oom); netif_carrier_off(dev); - + if (mp->phy) + phy_stop(mp->phy); free_irq(dev->irq, dev); port_reset(mp);