From: Joel Brobecker Date: Fri, 17 May 2013 06:53:53 +0000 (+0000) Subject: [gdbserver/lynx178]: Fix null_ptid -vs- minus_one_ptid confusion in comment X-Git-Tag: cygwin-1_7_19-release~198 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=58794e1a64f9bbef790a957791333b2a9d0e7d74;p=platform%2Fupstream%2Fbinutils.git [gdbserver/lynx178]: Fix null_ptid -vs- minus_one_ptid confusion in comment gdb/gdbserver/ChangeLog: * lynx-low.c (lynx_resume): Fix null_ptid/minus_one_ptid confusion in comment. --- diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index 5cc2c25..bc2ba38 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,5 +1,10 @@ 2013-05-17 Joel Brobecker + * lynx-low.c (lynx_resume): Fix null_ptid/minus_one_ptid + confusion in comment. + +2013-05-17 Joel Brobecker + * lynx-low.c (struct process_info_private): New type. (lynx_add_process): New function. (lynx_create_inferior, lynx_attach): Replace calls to diff --git a/gdb/gdbserver/lynx-low.c b/gdb/gdbserver/lynx-low.c index b4cb5d2..3dbffa5 100644 --- a/gdb/gdbserver/lynx-low.c +++ b/gdb/gdbserver/lynx-low.c @@ -284,7 +284,7 @@ lynx_resume (struct thread_resume *resume_info, size_t n) ? PTRACE_SINGLESTEP : PTRACE_CONT); const int signal = resume_info[0].sig; - /* If given a null_ptid, then try using the current_process' + /* If given a minus_one_ptid, then try using the current_process' private->last_wait_event_ptid. On most LynxOS versions, using any of the process' thread works well enough, but LynxOS 178 is a little more sensitive, and triggers some @@ -293,10 +293,10 @@ lynx_resume (struct thread_resume *resume_info, size_t n) if (ptid_equal (ptid, minus_one_ptid)) ptid = current_process()->private->last_wait_event_ptid; - /* The ptid might still be NULL; this can happen between the moment - we create the inferior or attach to a process, and the moment - we resume its execution for the first time. It is fine to - use the current_inferior's ptid in those cases. */ + /* The ptid might still be minus_one_ptid; this can happen between + the moment we create the inferior or attach to a process, and + the moment we resume its execution for the first time. It is + fine to use the current_inferior's ptid in those cases. */ if (ptid_equal (ptid, minus_one_ptid)) ptid = thread_to_gdb_id (current_inferior);