From: Pedro Alves Date: Thu, 4 Jul 2013 16:08:22 +0000 (+0000) Subject: value_bits_valid: Fix latent bug. X-Git-Tag: cygwin-1_7_21-release~32 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=58722cac5aa9ea0b18a8fe5e76031f62cea017bc;p=external%2Fbinutils.git value_bits_valid: Fix latent bug. Doing something else, I factored out the bits of the value_bits_valid function that actually handle the check_validity hook, and surprisingly found out that the result was misbehaving. Turns out value_bits_valid has a latent bug. If the value is not lval_computed, or doesn't have a check_validity hook, then we should assume the value is entirely valid, not invalid. This is currently masked by the value->optimized_out check -- I ran the testsuite with a gdb_assert(0) inserted in place of that return being touched by the patch, and it never triggers. Tested on x86_64 Fedora 17. gdb/ 2013-07-04 Pedro Alves * value.c (value_bits_valid): If the value is not lval_computed, or doesn't have a check_validity hook, assume the value is entirely valid. --- diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 77db200..2353e71 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2013-07-04 Pedro Alves + + * value.c (value_bits_valid): If the value is not lval_computed, + or doesn't have a check_validity hook, assume the value is entirely + valid. + 2013-07-04 Andrew Burgess * stack.c (read_frame_arg): No longer fetch lazy values. diff --git a/gdb/value.c b/gdb/value.c index ce4b13a..353f62a 100644 --- a/gdb/value.c +++ b/gdb/value.c @@ -1086,7 +1086,7 @@ value_bits_valid (const struct value *value, int offset, int length) return 1; if (value->lval != lval_computed || !value->location.computed.funcs->check_validity) - return 0; + return 1; return value->location.computed.funcs->check_validity (value, offset, length); }