From: Dan Carpenter Date: Mon, 16 Aug 2021 18:39:30 +0000 (+0300) Subject: iwlwifi: mvm: Fix an error code in iwl_mvm_up() X-Git-Tag: v6.6.17~7931^2~110^2~38^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=583d18336abdfb1b355270289ff8f6a2608ba905;p=platform%2Fkernel%2Flinux-rpi.git iwlwifi: mvm: Fix an error code in iwl_mvm_up() Return -ENODEV instead of success on this error path. Fixes: dd36a507c806 ("iwlwifi: mvm: look for the first supported channel when add/remove phy ctxt") Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/20210816183930.GA2068@kili Signed-off-by: Luca Coelho --- diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c index 9aa15f0..8537e1e 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c @@ -1709,8 +1709,10 @@ int iwl_mvm_up(struct iwl_mvm *mvm) while (!sband && i < NUM_NL80211_BANDS) sband = mvm->hw->wiphy->bands[i++]; - if (WARN_ON_ONCE(!sband)) + if (WARN_ON_ONCE(!sband)) { + ret = -ENODEV; goto error; + } chan = &sband->channels[0];