From: Jerry (Fangzhi) Zuo Date: Tue, 27 Nov 2018 15:51:12 +0000 (-0500) Subject: drm/amd/display: Fix NULL ptr when calculating refresh rate X-Git-Tag: v5.15~7216^2~13^2~6 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=58124bf8f4a6ee4c91845d3b48712e1ee8876bdc;p=platform%2Fkernel%2Flinux-starfive.git drm/amd/display: Fix NULL ptr when calculating refresh rate Calculate preferred refresh rate only when preferred mode exists. Signed-off-by: Jerry (Fangzhi) Zuo Reviewed-by: Bhawanpreet Lakha Signed-off-by: Alex Deucher --- diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index ce00e56..c791003 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -2848,7 +2848,7 @@ create_stream_for_sink(struct amdgpu_dm_connector *aconnector, bool native_mode_found = false; bool scale = dm_state ? (dm_state->scaling != RMX_OFF) : false; int mode_refresh; - int preferred_refresh; + int preferred_refresh = 0; struct dc_sink *sink = NULL; if (aconnector == NULL) { @@ -2902,13 +2902,12 @@ create_stream_for_sink(struct amdgpu_dm_connector *aconnector, decide_crtc_timing_for_drm_display_mode( &mode, preferred_mode, dm_state ? (dm_state->scaling != RMX_OFF) : false); + preferred_refresh = drm_mode_vrefresh(preferred_mode); } if (!dm_state) drm_mode_set_crtcinfo(&mode, 0); - preferred_refresh = drm_mode_vrefresh(preferred_mode); - /* * If scaling is enabled and refresh rate didn't change * we copy the vic and polarities of the old timings