From: Paul Cercueil Date: Thu, 20 Oct 2022 11:44:42 +0000 (+0100) Subject: leds: max8997: Don't error if there is no pdata X-Git-Tag: v6.6.7~3874^2~8 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=57d91e039070faa938622d28093ba1d031e29b3b;p=platform%2Fkernel%2Flinux-starfive.git leds: max8997: Don't error if there is no pdata The driver works just fine if no platform data is supplied. Signed-off-by: Paul Cercueil Reviewed-by: Andy Shevchenko Signed-off-by: Pavel Machek --- diff --git a/drivers/leds/leds-max8997.c b/drivers/leds/leds-max8997.c index c0bddb3..c8d7f55 100644 --- a/drivers/leds/leds-max8997.c +++ b/drivers/leds/leds-max8997.c @@ -238,11 +238,6 @@ static int max8997_led_probe(struct platform_device *pdev) char name[20]; int ret = 0; - if (pdata == NULL) { - dev_err(&pdev->dev, "no platform data\n"); - return -ENODEV; - } - led = devm_kzalloc(&pdev->dev, sizeof(*led), GFP_KERNEL); if (led == NULL) return -ENOMEM; @@ -258,7 +253,7 @@ static int max8997_led_probe(struct platform_device *pdev) led->iodev = iodev; /* initialize mode and brightness according to platform_data */ - if (pdata->led_pdata) { + if (pdata && pdata->led_pdata) { u8 mode = 0, brightness = 0; mode = pdata->led_pdata->mode[led->id];