From: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date: Wed, 17 Aug 2011 10:02:12 +0000 (+0100)
Subject: ofa: fingerprint creation can fail
X-Git-Tag: 1.19.3~507^2~16042^2~54
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=57ae8c4bf5bd8653f87f62b81a6531f812ee24a6;p=platform%2Fupstream%2Fgstreamer.git

ofa: fingerprint creation can fail

There does not seem to be a way to retrieve information
about why failure occured, unfortunately.
When failure occurs, do not post a NULL fingerprint tag.

https://bugzilla.gnome.org/show_bug.cgi?id=656641
---

diff --git a/ext/ofa/gstofa.c b/ext/ofa/gstofa.c
index 7e63eec..6081fdb 100644
--- a/ext/ofa/gstofa.c
+++ b/ext/ofa/gstofa.c
@@ -137,7 +137,8 @@ create_fingerprint (GstOFA * ofa)
     endianness = OFA_LITTLE_ENDIAN;
 
 
-  GST_DEBUG_OBJECT (ofa, "Generating fingerprint");
+  GST_DEBUG_OBJECT (ofa, "Generating fingerprint for %u samples",
+      available / 2);
 
   buf = gst_adapter_take_buffer (ofa->adapter, available);
 
@@ -145,16 +146,22 @@ create_fingerprint (GstOFA * ofa)
           endianness, GST_BUFFER_SIZE (buf) / 2, rate,
           (channels == 2) ? 1 : 0));
 
-  GST_DEBUG_OBJECT (ofa, "Generated fingerprint");
+  if (ofa->fingerprint) {
+    GST_INFO_OBJECT (ofa, "Generated fingerprint: %s", ofa->fingerprint);
+  } else {
+    GST_WARNING_OBJECT (ofa, "Failed to generate fingerprint");
+  }
 
   gst_buffer_unref (buf);
 
-  tags = gst_tag_list_new ();
-  gst_tag_list_add (tags, GST_TAG_MERGE_REPLACE,
-      GST_TAG_OFA_FINGERPRINT, ofa->fingerprint, NULL);
-  gst_element_found_tags (GST_ELEMENT (ofa), tags);
+  if (ofa->fingerprint) {
+    tags = gst_tag_list_new ();
+    gst_tag_list_add (tags, GST_TAG_MERGE_REPLACE,
+        GST_TAG_OFA_FINGERPRINT, ofa->fingerprint, NULL);
+    gst_element_found_tags (GST_ELEMENT (ofa), tags);
 
-  g_object_notify (G_OBJECT (ofa), "fingerprint");
+    g_object_notify (G_OBJECT (ofa), "fingerprint");
+  }
 
   ofa->record = FALSE;
 }