From: Wim Taymans <wim.taymans@collabora.co.uk>
Date: Wed, 17 Jun 2009 11:18:18 +0000 (+0200)
Subject: audiosink: free the ringbuffer when going to NULL
X-Git-Tag: RELEASE-0.10.24~141
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=57a13f28de3b062995ff3eeccc12d5277bf562ae;p=platform%2Fupstream%2Fgst-plugins-base.git

audiosink: free the ringbuffer when going to NULL

Unparent and free the ringbuffer when going to NULL, like we do with the
audiosrc element. We can do this now because we correctly manage the time
jumping back to 0.
---

diff --git a/gst-libs/gst/audio/gstbaseaudiosink.c b/gst-libs/gst/audio/gstbaseaudiosink.c
index a347ec2..7007e4e 100644
--- a/gst-libs/gst/audio/gstbaseaudiosink.c
+++ b/gst-libs/gst/audio/gstbaseaudiosink.c
@@ -1804,12 +1804,10 @@ gst_base_audio_sink_change_state (GstElement * element,
       gst_ring_buffer_activate (sink->ringbuffer, FALSE);
       gst_ring_buffer_release (sink->ringbuffer);
       gst_ring_buffer_close_device (sink->ringbuffer);
-#if 0
       GST_OBJECT_LOCK (sink);
       gst_object_unparent (GST_OBJECT_CAST (sink->ringbuffer));
       sink->ringbuffer = NULL;
       GST_OBJECT_UNLOCK (sink);
-#endif
       break;
     default:
       break;