From: Srinivas Pandruvada Date: Wed, 22 Feb 2023 11:26:29 +0000 (-0800) Subject: tools/power/x86/intel-speed-select: Add missing free cpuset X-Git-Tag: v6.6.17~5045^2~39^2~5 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=57797f19d5a78b5a84b7452790f7da22865f6420;p=platform%2Fkernel%2Flinux-rpi.git tools/power/x86/intel-speed-select: Add missing free cpuset During perf level change cpuset is allocated but not freed. Add free_cpu_set() in success and failure path. Although this is not an issue, as the program will exit after processing of online/offline, but for completeness add the free_cpu_set(). Signed-off-by: Srinivas Pandruvada --- diff --git a/tools/power/x86/intel-speed-select/isst-config.c b/tools/power/x86/intel-speed-select/isst-config.c index a040056..a9bd87b 100644 --- a/tools/power/x86/intel-speed-select/isst-config.c +++ b/tools/power/x86/intel-speed-select/isst-config.c @@ -1271,7 +1271,7 @@ display_result: ret = isst_get_coremask_info(id, tdp_level, &ctdp_level); if (ret) { isst_display_error_info_message(1, "Can't get coremask, online/offline option is ignored", 0, 0); - return; + goto free_mask; } if (ctdp_level.cpu_count) { int i, max_cpus = get_topo_max_cpus(); @@ -1288,6 +1288,8 @@ display_result: } } } +free_mask: + free_cpu_set(ctdp_level.core_cpumask); } }