From: wingo@igalia.com Date: Tue, 11 Jun 2013 14:45:17 +0000 (+0000) Subject: Disable --harmony -> --harmony-generators implication X-Git-Tag: upstream/4.7.83~13906 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5760c7b5983826d53ffd266aaf9556584efc4d3b;p=platform%2Fupstream%2Fv8.git Disable --harmony -> --harmony-generators implication A GC-related bug has started showing up after r15060 that unfortunately I haven't been able to reproduce. Disable generators by default for the Canary push. R=danno@chromium.org BUG= Review URL: https://codereview.chromium.org/16638011 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15065 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- diff --git a/src/flag-definitions.h b/src/flag-definitions.h index 49dac4a..b70a532 100644 --- a/src/flag-definitions.h +++ b/src/flag-definitions.h @@ -178,7 +178,8 @@ DEFINE_implication(harmony, harmony_symbols) DEFINE_implication(harmony, harmony_proxies) DEFINE_implication(harmony, harmony_collections) DEFINE_implication(harmony, harmony_observation) -DEFINE_implication(harmony, harmony_generators) +// TODO(wingo): Re-enable when GC bug that appeared in r15060 is gone. +// DEFINE_implication(harmony, harmony_generators) DEFINE_implication(harmony, harmony_iteration) DEFINE_implication(harmony_modules, harmony_scoping) DEFINE_implication(harmony_observation, harmony_collections) diff --git a/test/mjsunit/harmony/iteration-semantics.js b/test/mjsunit/harmony/iteration-semantics.js index 6215522..96b6d14 100644 --- a/test/mjsunit/harmony/iteration-semantics.js +++ b/test/mjsunit/harmony/iteration-semantics.js @@ -25,7 +25,7 @@ // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -// Flags: --harmony +// Flags: --harmony --harmony-generators // Test for-of semantics. diff --git a/test/mjsunit/mjsunit.status b/test/mjsunit/mjsunit.status index 585d503..8d6274b 100644 --- a/test/mjsunit/mjsunit.status +++ b/test/mjsunit/mjsunit.status @@ -47,6 +47,10 @@ regress/regress-crbug-160010: SKIP stack-traces-gc: PASS || FAIL ############################################################################## +# TODO(wingo): Re-enable when GC bug from r15060 is solved. +harmony/generators-iteration: SKIP + +############################################################################## # Too slow in debug mode with --stress-opt mode. compiler/regress-stacktrace-methods: PASS, SKIP if $mode == debug compiler/regress-funcaller: PASS, SKIP if $mode == debug