From: Tim-Philipp Müller Date: Sat, 7 Dec 2019 21:13:09 +0000 (+0000) Subject: tests: simple-launch-lines: remove use of unused HAVE_LIBVISUAL define X-Git-Tag: 1.19.3~511^2~835 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=574d097d43f68460d0b3596e60257ca7190b0b1f;p=platform%2Fupstream%2Fgstreamer.git tests: simple-launch-lines: remove use of unused HAVE_LIBVISUAL define This is not set anywhere, and it's pretty clear the pipeline in question has not been tested in a long time. Disable test with a FIXME, test needs to be rewritten to not use real output devices. --- diff --git a/tests/check/pipelines/simple-launch-lines.c b/tests/check/pipelines/simple-launch-lines.c index 2334265..e77d51a 100644 --- a/tests/check/pipelines/simple-launch-lines.c +++ b/tests/check/pipelines/simple-launch-lines.c @@ -120,12 +120,23 @@ GST_START_TEST (test_element_negotiation) GST_MESSAGE_ANY & ~(GST_MESSAGE_ERROR | GST_MESSAGE_WARNING), GST_MESSAGE_UNKNOWN); -#ifdef HAVE_LIBVISUAL - s = "audiotestsrc num-buffers=30 ! tee name=t ! alsasink t. ! audioconvert ! " - "libvisual_lv_scope ! videoconvert ! xvimagesink"; - run_pipeline (setup_pipeline (s), s, - GST_MESSAGE_ANY & ~(GST_MESSAGE_ERROR | GST_MESSAGE_WARNING), - GST_MESSAGE_UNKNOWN); + /* FIXME: don't use real audio/video outputs */ +#if 0 + { + gboolean have_libvisual_lv_scope; + + have_libvisual_lv_scope = + gst_registry_check_feature_version (gst_registry_get (), + "libvisual_lv_scope", GST_VERSION_MAJOR, GST_VERSION_MINOR, 0); + + if (have_libvisual_lv_scope) { + s = "audiotestsrc num-buffers=30 ! tee name=t ! alsasink t. ! " + "audioconvert ! libvisual_lv_scope ! videoconvert ! xvimagesink"; + run_pipeline (setup_pipeline (s), s, + GST_MESSAGE_ANY & ~(GST_MESSAGE_ERROR | GST_MESSAGE_WARNING), + GST_MESSAGE_UNKNOWN); + } + } #endif }