From: Jean-Philippe Andre <jp.andre@samsung.com>
Date: Fri, 14 Mar 2014 07:55:33 +0000 (+0900)
Subject: Evas filters: Fix invalid error check in mapped_blend()
X-Git-Tag: v1.9.0+464+gcaabcbe~123
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=571d7b6287fde386cc9689aaafea8b8f57b3571b;p=platform%2Fupstream%2Fefl.git

Evas filters: Fix invalid error check in mapped_blend()

Some filters would not render because I checked the wrong
value. image_draw can not fail, it only returns a bool
indicating asynchronous processing.
---

diff --git a/src/lib/evas/filters/evas_filter_blend.c b/src/lib/evas/filters/evas_filter_blend.c
index a3aa21c..1e5260d 100644
--- a/src/lib/evas/filters/evas_filter_blend.c
+++ b/src/lib/evas/filters/evas_filter_blend.c
@@ -324,12 +324,12 @@ _mapped_blend(void *data, void *drawctx,
         DBG("blend: %d,%d,%d,%d --> %d,%d,%d,%d (from %dx%d to %dx%d +%d,%d)",
             0, 0, sw, sh, dx, dy, cols, rows, sw, sh, dw, dh, dx, dy);
 
-        ret = image_draw(data, drawctx, out, in,
-                         sx, sy, cols, rows, // src
-                         dx, dy, cols, rows, // dst
-                         EINA_TRUE, // smooth
-                         EINA_FALSE); // Not async
-        return ret;
+        image_draw(data, drawctx, out, in,
+                   sx, sy, cols, rows, // src
+                   dx, dy, cols, rows, // dst
+                   EINA_TRUE, // smooth
+                   EINA_FALSE); // Not async
+        return EINA_TRUE;
      }
 
    if (fillmode & EVAS_FILTER_FILL_MODE_REPEAT_X)
@@ -462,11 +462,10 @@ _mapped_blend(void *data, void *drawctx,
                  col, row, src_x, src_y, src_w, src_h,
                  dst_x, dst_y, dst_w, dst_h,
                  sw, sh, dw, dh);
-             ret = image_draw(data, drawctx, out, in,
-                              src_x, src_y, src_w, src_h,
-                              dst_x, dst_y, dst_w, dst_h,
-                              EINA_TRUE, EINA_FALSE);
-             if (!ret) return EINA_FALSE;
+             image_draw(data, drawctx, out, in,
+                        src_x, src_y, src_w, src_h,
+                        dst_x, dst_y, dst_w, dst_h,
+                        EINA_TRUE, EINA_FALSE);
           }
      }
    return ret;