From: Gao Xiang <hsiangkao@linux.alibaba.com>
Date: Fri, 2 Aug 2024 06:23:16 +0000 (+0800)
Subject: erofs-utils: lib: fix potential memory leak in erofs_export_xattr_ibody()
X-Git-Tag: v1.8~10
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=56afdb83ffa4cf655af1fe04cdecb898db1fcd60;p=platform%2Fupstream%2Ferofs-utils.git

erofs-utils: lib: fix potential memory leak in erofs_export_xattr_ibody()

Although it won't happen in reality except for bugs.

Fixes: 8f93c2f83962 ("erofs-utils: mkfs: support inline xattr reservation for rootdirs")
Coverity-id: 507395
Reviewed-by: Sandeep Dhavale <dhavale@google.com>
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Link: https://lore.kernel.org/r/20240802062316.2368403-1-hsiangkao@linux.alibaba.com
---

diff --git a/lib/xattr.c b/lib/xattr.c
index f860f2e..651657f 100644
--- a/lib/xattr.c
+++ b/lib/xattr.c
@@ -1020,6 +1020,7 @@ char *erofs_export_xattr_ibody(struct erofs_inode *inode)
 		memset(buf + p, 0, size - p);
 	} else if (__erofs_unlikely(p > size)) {
 		DBG_BUGON(1);
+		free(buf);
 		return ERR_PTR(-EFAULT);
 	}
 	return buf;