From: Anand Jain Date: Thu, 15 Feb 2018 10:07:59 +0000 (+0800) Subject: btrfs: use ASSERT to report logical error in cow_file_range() X-Git-Tag: v5.15~8810^2~152 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=566b1760b42be7c99c02e894b1ec9a707c2e83d1;p=platform%2Fkernel%2Flinux-starfive.git btrfs: use ASSERT to report logical error in cow_file_range() Use ASSERT to report logical error in cow_file_range(), also move it a bit closer to when the num_bytes is derived. The extent start could be (u64)-1 in some cases, the assert should catch that we do not accidentally pass it to cow_file_range. Signed-off-by: Anand Jain Reviewed-by: Nikolay Borisov Reviewed-by: David Sterba Signed-off-by: David Sterba --- diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index e90d7c5..28491a8 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -978,6 +978,7 @@ static noinline int cow_file_range(struct inode *inode, num_bytes = ALIGN(end - start + 1, blocksize); num_bytes = max(blocksize, num_bytes); + ASSERT(num_bytes <= btrfs_super_total_bytes(fs_info->super_copy)); inode_should_defrag(BTRFS_I(inode), start, end, num_bytes, SZ_64K); @@ -1008,8 +1009,6 @@ static noinline int cow_file_range(struct inode *inode, } } - BUG_ON(num_bytes > btrfs_super_total_bytes(fs_info->super_copy)); - alloc_hint = get_extent_allocation_hint(inode, start, num_bytes); btrfs_drop_extent_cache(BTRFS_I(inode), start, start + num_bytes - 1, 0);