From: Nirbheek Chauhan <nirbheek@centricular.com>
Date: Wed, 5 Sep 2018 12:00:27 +0000 (+0530)
Subject: Rename --no-error to --werror and flip default
X-Git-Tag: 1.19.3~481^2~294
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=56130b0edd1b05601ed79590859c4112ff2ee235;p=platform%2Fupstream%2Fgstreamer.git

Rename --no-error to --werror and flip default

We should not default to -Werror because that's not what we default to
anywhere in gstreamer, and it's bad for releases anyway. The CI will
be fixed to pass --werror manually.
---

diff --git a/setup.py b/setup.py
index 5f286b9..fccf416 100755
--- a/setup.py
+++ b/setup.py
@@ -23,9 +23,9 @@ class GstBuildConfigurer:
         self.args = args
 
     def get_configs(self):
-        if self.options.no_error:
-            return []
-        return ['--werror']
+        if self.options.werror:
+            return ['--werror']
+        return []
 
     def configure_meson(self):
         if not self.options.reconfigure:
@@ -74,7 +74,7 @@ if __name__ == "__main__":
                         ' You can also use `ninja reconfigure` to just'
                         ' make sure meson is rerun but the build folder'
                         ' is kept.')
-    parser.add_argument("--no-error", action='store_true',
+    parser.add_argument("--werror", action='store_true',
                         default=False, help="Do not error out on warnings")
 
     options, args = parser.parse_known_args()