From: dongsug-song <35130733+dongsug-song@users.noreply.github.com> Date: Thu, 17 Oct 2019 01:46:52 +0000 (+0900) Subject: [NUI] Fix build warnings (#1084) X-Git-Tag: 5.5_M2~13 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=55f2b9548291c33330d3b813f8c8911ad2b0d57c;p=platform%2Fcore%2Fcsapi%2Ftizenfx.git [NUI] Fix build warnings (#1084) --- diff --git a/src/Tizen.NUI.Components/Controls/Button.cs b/src/Tizen.NUI.Components/Controls/Button.cs index 1eaaa2b..f6340ba 100755 --- a/src/Tizen.NUI.Components/Controls/Button.cs +++ b/src/Tizen.NUI.Components/Controls/Button.cs @@ -725,7 +725,7 @@ namespace Tizen.NUI.Components } } - // + /// /// Icon padding in Button, work only when show icon and text. /// /// 6 @@ -756,7 +756,7 @@ namespace Tizen.NUI.Components } } - // + /// /// Text padding in Button, work only when show icon and text. /// /// 6 diff --git a/src/Tizen.NUI.Components/Controls/FlexibleView/FlexibleView.cs b/src/Tizen.NUI.Components/Controls/FlexibleView/FlexibleView.cs index 773eb3a..e9bc20a 100755 --- a/src/Tizen.NUI.Components/Controls/FlexibleView/FlexibleView.cs +++ b/src/Tizen.NUI.Components/Controls/FlexibleView/FlexibleView.cs @@ -597,7 +597,7 @@ namespace Tizen.NUI.Components float extent = mLayout.ComputeScrollExtent(); float range = mLayout.ComputeScrollRange(); - if(range == 0) + if (range == 0) { return; } @@ -661,7 +661,7 @@ namespace Tizen.NUI.Components mAdapter.OnFocusChange(this, mFocusedItemIndex, nextFocusPosition); mFocusedItemIndex = nextFocusPosition; - + ShowScrollBar(); } @@ -1069,7 +1069,7 @@ namespace Tizen.NUI.Components [EditorBrowsable(EditorBrowsableState.Never)] public void NotifyItemMoved(int fromPosition, int toPosition) { - + } private void OnItemEvent(object sender, ItemEventArgs e) @@ -1871,7 +1871,7 @@ namespace Tizen.NUI.Components // Favor the "start" layout direction over the end when bringing one side or the other // of a large rect into view. If we decide to bring in end because start is already // visible, limit the scroll such that start won't go out of bounds. - int dx= offScreenLeft != 0 ? offScreenLeft + int dx = offScreenLeft != 0 ? offScreenLeft : Math.Min(childLeft - parentLeft, offScreenRight); // Favor bringing the top into view over the bottom. If top is already visible and @@ -1946,11 +1946,19 @@ namespace Tizen.NUI.Components } } + /// + /// FindFirstVisibleItemView + /// + /// ViewHolder protected virtual ViewHolder FindFirstVisibleItemView() { return null; } + /// + /// FindLastVisibleItemView + /// + /// ViewHolder protected virtual ViewHolder FindLastVisibleItemView() { return null; @@ -1982,50 +1990,36 @@ namespace Tizen.NUI.Components [EditorBrowsable(EditorBrowsableState.Never)] public class ViewHolder { - /** - * This ViewHolder has been bound to a position; AdapterPosition, mItemId and mItemViewType - * are all valid. - */ + // This ViewHolder has been bound to a position; AdapterPosition, mItemId and mItemViewType + // are all valid. //static readonly int FLAG_BOUND = 1 << 0; - /** - * The data this ViewHolder's view reflects is stale and needs to be rebound - * by the adapter. AdapterPosition and mItemId are consistent. - */ + // The data this ViewHolder's view reflects is stale and needs to be rebound + // by the adapter. AdapterPosition and mItemId are consistent. //static readonly int FLAG_UPDATE = 1 << 1; - /** - * This ViewHolder's data is invalid. The identity implied by AdapterPosition and mItemId - * are not to be trusted and may no longer match the item view type. - * This ViewHolder must be fully rebound to different data. - */ + // This ViewHolder's data is invalid. The identity implied by AdapterPosition and mItemId + // are not to be trusted and may no longer match the item view type. + // This ViewHolder must be fully rebound to different data. //static readonly int FLAG_INVALID = 1 << 2; - /** - * This ViewHolder points at data that represents an item previously removed from the - * data set. Its view may still be used for things like outgoing animations. - */ + // This ViewHolder points at data that represents an item previously removed from the + // data set. Its view may still be used for things like outgoing animations. //static readonly int FLAG_REMOVED = 1 << 3; - /** - * This ViewHolder should not be recycled. This flag is set via setIsRecyclable() - * and is intended to keep views around during animations. - */ + // This ViewHolder should not be recycled. This flag is set via setIsRecyclable() + // and is intended to keep views around during animations. //static readonly int FLAG_NOT_RECYCLABLE = 1 << 4; - /** - * This ViewHolder is returned from scrap which means we are expecting an addView call - * for this itemView. When returned from scrap, ViewHolder stays in the scrap list until - * the end of the layout pass and then recycled by RecyclerView if it is not added back to - * the RecyclerView. - */ + // This ViewHolder is returned from scrap which means we are expecting an addView call + // for this itemView. When returned from scrap, ViewHolder stays in the scrap list until + // the end of the layout pass and then recycled by RecyclerView if it is not added back to + // the RecyclerView. //static readonly int FLAG_RETURNED_FROM_SCRAP = 1 << 5; - /** - * This ViewHolder is fully managed by the LayoutManager. We do not scrap, recycle or remove - * it unless LayoutManager is replaced. - * It is still fully visible to the LayoutManager. - */ + // This ViewHolder is fully managed by the LayoutManager. We do not scrap, recycle or remove + // it unless LayoutManager is replaced. + // It is still fully visible to the LayoutManager. //static readonly int FLAG_IGNORE = 1 << 7; private int mFlags; @@ -2452,7 +2446,7 @@ namespace Tizen.NUI.Components private class ChildHelper { private FlexibleView mFlexibleView; - + private List mViewList = new List(); //private List mRemovePendingViews; @@ -2470,7 +2464,7 @@ namespace Tizen.NUI.Components public void Clear() { - foreach(ViewHolder holder in mViewList) + foreach (ViewHolder holder in mViewList) { mFlexibleView.Remove(holder.ItemView); @@ -2502,7 +2496,7 @@ namespace Tizen.NUI.Components if (!itemViewTable.ContainsKey(holder.ItemView.ID)) { mTapGestureDetector.Attach(holder.ItemView); - holder.ItemView.TouchEvent += OnTouchEvent; + holder.ItemView.TouchEvent += OnTouchEvent; } itemViewTable[holder.ItemView.ID] = holder; diff --git a/src/Tizen.NUI.Components/Controls/FlexibleView/LinearLayoutManager.cs b/src/Tizen.NUI.Components/Controls/FlexibleView/LinearLayoutManager.cs index 3db688d..daf2327 100755 --- a/src/Tizen.NUI.Components/Controls/FlexibleView/LinearLayoutManager.cs +++ b/src/Tizen.NUI.Components/Controls/FlexibleView/LinearLayoutManager.cs @@ -244,7 +244,7 @@ namespace Tizen.NUI.Components /// /// Scroll horizontally by dy pixels in screen coordinates. /// - /// distance to scroll in pixels. Y increases as scroll position approaches the top. + /// distance to scroll in pixels. Y increases as scroll position approaches the top. /// Recycler to use for fetching potentially cached views for a position /// Specify if the scroll need animation /// 6 @@ -947,6 +947,10 @@ namespace Tizen.NUI.Components mLayoutState.Extra = mOrientationHelper.GetStartAfterPadding(); } + /// + /// FindFirstVisibleItemView + /// + /// FlexibleView.ViewHolder protected override FlexibleView.ViewHolder FindFirstVisibleItemView() { int childCount = ChildCount; @@ -1007,6 +1011,10 @@ namespace Tizen.NUI.Components return null; } + /// + /// FindLastVisibleItemView + /// + /// FlexibleView.ViewHolder protected override FlexibleView.ViewHolder FindLastVisibleItemView() { int childCount = ChildCount; diff --git a/src/Tizen.NUI.Components/Controls/Scrollbar.cs b/src/Tizen.NUI.Components/Controls/Scrollbar.cs index 1a5ffd6..4210f60 100755 --- a/src/Tizen.NUI.Components/Controls/Scrollbar.cs +++ b/src/Tizen.NUI.Components/Controls/Scrollbar.cs @@ -324,7 +324,7 @@ namespace Tizen.NUI.Components /// Method to set current value. The thumb object would move to the corresponding position with animation or not. /// /// The special current value. - /// Enable move with animation or not, the default value is true. + /// Enable move with animation or not, the default value is true. /// Throw when current size is less than the min value, or greater than the max value. /// /// diff --git a/src/Tizen.NUI.Components/Controls/Toast.cs b/src/Tizen.NUI.Components/Controls/Toast.cs index 9eece3c..57af5b1 100755 --- a/src/Tizen.NUI.Components/Controls/Toast.cs +++ b/src/Tizen.NUI.Components/Controls/Toast.cs @@ -42,9 +42,9 @@ namespace Tizen.NUI.Components private readonly uint textLineSpace = 4; private readonly float textPointSize = 38; private readonly int textPaddingLeft = 96; - private readonly int textPaddingRight = 96; + //private readonly int textPaddingRight = 96; private readonly int textPaddingTop = 38; - private readonly int textPaddingBottom = 38; + //private readonly int textPaddingBottom = 38; private readonly uint duration = 3000; /// diff --git a/src/Tizen.NUI.Components/Utils/StyleManager.cs b/src/Tizen.NUI.Components/Utils/StyleManager.cs index e9fe938..29915b3 100755 --- a/src/Tizen.NUI.Components/Utils/StyleManager.cs +++ b/src/Tizen.NUI.Components/Utils/StyleManager.cs @@ -165,6 +165,10 @@ namespace Tizen.NUI.Components [EditorBrowsable(EditorBrowsableState.Never)] public class ThemeChangeEventArgs : EventArgs { + /// + /// CurrentTheme + /// + [EditorBrowsable(EditorBrowsableState.Never)] public string CurrentTheme; } } diff --git a/src/Tizen.NUI/src/internal/ItemView.cs b/src/Tizen.NUI/src/internal/ItemView.cs index 64dc8fc..4a4b60b 100755 --- a/src/Tizen.NUI/src/internal/ItemView.cs +++ b/src/Tizen.NUI/src/internal/ItemView.cs @@ -80,54 +80,93 @@ namespace Tizen.NUI } } + /// + /// Property for ItemView. This is internal use only, so not recommended to use. Need to use ItemView's properties. + /// [Obsolete("Deprecated in API6; Will be removed in API9.")] [EditorBrowsable(EditorBrowsableState.Never)] public new class Property { + /// + /// LAYOUT. This is internal use only, so not recommended to use. Need to use ItemView's properties. + /// [Obsolete("Deprecated in API6; Will be removed in API9.")] [EditorBrowsable(EditorBrowsableState.Never)] public static readonly int LAYOUT = Interop.ItemView.ItemView_Property_LAYOUT_get(); + /// + /// MINIMUM_SWIPE_SPEED. This is internal use only, so not recommended to use. Need to use ItemView's properties. + /// [Obsolete("Deprecated in API6; Will be removed in API9.")] [EditorBrowsable(EditorBrowsableState.Never)] public static readonly int MINIMUM_SWIPE_SPEED = Interop.ItemView.ItemView_Property_MINIMUM_SWIPE_SPEED_get(); + /// + /// MINIMUM_SWIPE_DISTANCE. This is internal use only, so not recommended to use. Need to use ItemView's properties. + /// [Obsolete("Deprecated in API6; Will be removed in API9.")] [EditorBrowsable(EditorBrowsableState.Never)] public static readonly int MINIMUM_SWIPE_DISTANCE = Interop.ItemView.ItemView_Property_MINIMUM_SWIPE_DISTANCE_get(); + /// + /// WHEEL_SCROLL_DISTANCE_STEP. This is internal use only, so not recommended to use. Need to use ItemView's properties. + /// [Obsolete("Deprecated in API6; Will be removed in API9.")] [EditorBrowsable(EditorBrowsableState.Never)] public static readonly int WHEEL_SCROLL_DISTANCE_STEP = Interop.ItemView.ItemView_Property_WHEEL_SCROLL_DISTANCE_STEP_get(); + /// + /// SNAP_TO_ITEM_ENABLED. This is internal use only, so not recommended to use. Need to use ItemView's properties. + /// [Obsolete("Deprecated in API6; Will be removed in API9.")] [EditorBrowsable(EditorBrowsableState.Never)] public static readonly int SNAP_TO_ITEM_ENABLED = Interop.ItemView.ItemView_Property_SNAP_TO_ITEM_ENABLED_get(); + /// + /// REFRESH_INTERVAL. This is internal use only, so not recommended to use. Need to use ItemView's properties. + /// [Obsolete("Deprecated in API6; Will be removed in API9.")] [EditorBrowsable(EditorBrowsableState.Never)] public static readonly int REFRESH_INTERVAL = Interop.ItemView.ItemView_Property_REFRESH_INTERVAL_get(); + /// + /// LAYOUT_POSITION. This is internal use only, so not recommended to use. Need to use ItemView's properties. + /// [Obsolete("Deprecated in API6; Will be removed in API9.")] [EditorBrowsable(EditorBrowsableState.Never)] public static readonly int LAYOUT_POSITION = Interop.ItemView.ItemView_Property_LAYOUT_POSITION_get(); + /// + /// SCROLL_SPEED. This is internal use only, so not recommended to use. Need to use ItemView's properties. + /// [Obsolete("Deprecated in API6; Will be removed in API9.")] [EditorBrowsable(EditorBrowsableState.Never)] public static readonly int SCROLL_SPEED = Interop.ItemView.ItemView_Property_SCROLL_SPEED_get(); + /// + /// OVERSHOOT. This is internal use only, so not recommended to use. Need to use ItemView's properties. + /// [Obsolete("Deprecated in API6; Will be removed in API9.")] [EditorBrowsable(EditorBrowsableState.Never)] public static readonly int OVERSHOOT = Interop.ItemView.ItemView_Property_OVERSHOOT_get(); + /// + /// SCROLL_DIRECTION. This is internal use only, so not recommended to use. Need to use ItemView's properties. + /// [Obsolete("Deprecated in API6; Will be removed in API9.")] [EditorBrowsable(EditorBrowsableState.Never)] public static readonly int SCROLL_DIRECTION = Interop.ItemView.ItemView_Property_SCROLL_DIRECTION_get(); + /// + /// LAYOUT_ORIENTATION. This is internal use only, so not recommended to use. Need to use ItemView's properties. + /// [Obsolete("Deprecated in API6; Will be removed in API9.")] [EditorBrowsable(EditorBrowsableState.Never)] public static readonly int LAYOUT_ORIENTATION = Interop.ItemView.ItemView_Property_LAYOUT_ORIENTATION_get(); + /// + /// SCROLL_CONTENT_SIZE. This is internal use only, so not recommended to use. Need to use ItemView's properties. + /// [Obsolete("Deprecated in API6; Will be removed in API9.")] [EditorBrowsable(EditorBrowsableState.Never)] public static readonly int SCROLL_CONTENT_SIZE = Interop.ItemView.ItemView_Property_SCROLL_CONTENT_SIZE_get(); diff --git a/src/Tizen.NUI/src/internal/Layouting/LayoutController.cs b/src/Tizen.NUI/src/internal/Layouting/LayoutController.cs index 9fc6288..d97dd08 100755 --- a/src/Tizen.NUI/src/internal/Layouting/LayoutController.cs +++ b/src/Tizen.NUI/src/internal/Layouting/LayoutController.cs @@ -39,9 +39,6 @@ namespace Tizen.NUI event Callback _instance; - // A Flag to check if it is already disposed. - private bool disposed = false; - private Window _window; Animation _coreAnimation; diff --git a/src/Tizen.NUI/src/public/Accessibility.cs b/src/Tizen.NUI/src/public/Accessibility.cs index a0fb0aa..ec68539 100755 --- a/src/Tizen.NUI/src/public/Accessibility.cs +++ b/src/Tizen.NUI/src/public/Accessibility.cs @@ -38,9 +38,11 @@ namespace Tizen.NUI dummy = new View(); dummy.Name = "dali-atspi-singleton"; } + /// + /// destructor. This is HiddenAPI. recommended not to use in public. + /// ~Accessibility() { - } #endregion Constructor, Distructor, Dispose diff --git a/src/Tizen.NUI/src/public/Size.cs b/src/Tizen.NUI/src/public/Size.cs index 9da40f9..eb687bb 100755 --- a/src/Tizen.NUI/src/public/Size.cs +++ b/src/Tizen.NUI/src/public/Size.cs @@ -34,9 +34,6 @@ namespace Tizen.NUI private global::System.Runtime.InteropServices.HandleRef swigCPtr; - //A Flag to check who called Dispose(). (By User or DisposeQueue) - private bool isDisposeQueued = false; - /// /// The constructor. ///