From: Andrew Au Date: Thu, 29 Jul 2021 07:04:47 +0000 (-0700) Subject: We should check against alloc_allocated instead of heap_segment_allocated for ephemer... X-Git-Tag: submit/tizen/20220302.040122~21^2^2~190 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=55dd35d0450deb45e679d9cd8a1d2d6b9ce87f28;p=platform%2Fcore%2Fdotnet%2Fdiagnostics.git We should check against alloc_allocated instead of heap_segment_allocated for ephemeral segment (#2450) --- diff --git a/src/SOS/Strike/eeheap.cpp b/src/SOS/Strike/eeheap.cpp index 9651fe234..3fcec0382 100644 --- a/src/SOS/Strike/eeheap.cpp +++ b/src/SOS/Strike/eeheap.cpp @@ -700,7 +700,12 @@ BOOL GCObjInSegment(TADDR taddrObj, const GCHeapDetails &heap, ExtOut("Error requesting heap segment %p\n", SOS_PTR(taddrSeg)); return FALSE; } - if (taddrObj >= TO_TADDR(dacpSeg.mem) && taddrObj && taddrObj < TO_TADDR(dacpSeg.allocated)) + TADDR allocated = TO_TADDR(dacpSeg.allocated); + if (taddrSeg == TO_TADDR(heap.ephemeral_heap_segment)) + { + allocated = TO_TADDR(heap.alloc_allocated); + } + if (taddrObj >= TO_TADDR(dacpSeg.mem) && taddrObj < allocated) { rngSeg.segAddr = (TADDR)dacpSeg.segmentAddr; rngSeg.start = (TADDR)dacpSeg.mem; @@ -776,7 +781,7 @@ BOOL GCObjInLargeSegment(TADDR taddrObj, const GCHeapDetails &heap, TADDR_SEGINF ExtOut("Error requesting heap segment %p\n", SOS_PTR(taddrSeg)); return FALSE; } - if (taddrObj >= TO_TADDR(dacpSeg.mem) && taddrObj && taddrObj < TO_TADDR(dacpSeg.allocated)) + if (taddrObj >= TO_TADDR(dacpSeg.mem) && taddrObj < TO_TADDR(dacpSeg.allocated)) { rngSeg.segAddr = (TADDR)dacpSeg.segmentAddr; rngSeg.start = (TADDR)dacpSeg.mem; @@ -809,7 +814,7 @@ BOOL GCObjInPinnedObjectSegment(TADDR taddrObj, const GCHeapDetails &heap, TADDR ExtOut("Error requesting heap segment %p\n", SOS_PTR(taddrSeg)); return FALSE; } - if (taddrObj >= TO_TADDR(dacpSeg.mem) && taddrObj && taddrObj < TO_TADDR(dacpSeg.allocated)) + if (taddrObj >= TO_TADDR(dacpSeg.mem) && taddrObj < TO_TADDR(dacpSeg.allocated)) { rngSeg.segAddr = (TADDR)dacpSeg.segmentAddr; rngSeg.start = (TADDR)dacpSeg.mem;