From: Rami Rosen <ramirose@gmail.com>
Date: Thu, 3 Jun 2010 05:02:29 +0000 (+0000)
Subject: fix return value of __pppoe_xmit() method.
X-Git-Tag: v3.12-rc1~9497^2~651
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=55c95e738da85373965cb03b4f975d0fd559865b;p=kernel%2Fkernel-generic.git

fix return value of __pppoe_xmit() method.

Hi,
 __pppoe_xmit() in drivers/net/pppoe always returns 1.
When the methods fails (via goto abort), it should return 0 and not 1.

Regards,
Rami Rosen

Signed-off-by: Rami Rosen <ramirose@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/pppoe.c b/drivers/net/pppoe.c
index 805b64d..7ebb8e8 100644
--- a/drivers/net/pppoe.c
+++ b/drivers/net/pppoe.c
@@ -949,7 +949,7 @@ static int __pppoe_xmit(struct sock *sk, struct sk_buff *skb)
 
 abort:
 	kfree_skb(skb);
-	return 1;
+	return 0;
 }
 
 /************************************************************************