From: Ville Syrjälä Date: Tue, 15 Mar 2016 14:39:59 +0000 (+0200) Subject: drm/i915: Remove the "three times for luck" trick from vlv_enable_pll() X-Git-Tag: v4.14-rc1~2738^2~45^2~392 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5593946921834a63d89c595ef8459c50d30f5438;p=platform%2Fkernel%2Flinux-rpi.git drm/i915: Remove the "three times for luck" trick from vlv_enable_pll() VLV DPLL is somewhat sane and doesn't run on luck. Signed-off-by: Ville Syrjälä Link: http://patchwork.freedesktop.org/patch/msgid/1458052809-23426-7-git-send-email-ville.syrjala@linux.intel.com Acked-by: Jani Nikula --- diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 4fbff48..cf16bdb 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -1546,17 +1546,6 @@ static void vlv_enable_pll(struct intel_crtc *crtc, I915_WRITE(DPLL_MD(pipe), pipe_config->dpll_hw_state.dpll_md); POSTING_READ(DPLL_MD(pipe)); - - /* We do this three times for luck */ - I915_WRITE(reg, dpll); - POSTING_READ(reg); - udelay(150); /* wait for warmup */ - I915_WRITE(reg, dpll); - POSTING_READ(reg); - udelay(150); /* wait for warmup */ - I915_WRITE(reg, dpll); - POSTING_READ(reg); - udelay(150); /* wait for warmup */ } static void chv_enable_pll(struct intel_crtc *crtc,