From: Alp Toker <alp@nuanti.com>
Date: Tue, 3 Jun 2014 03:01:03 +0000 (+0000)
Subject: Process::GetRandomNumber(): fix insecure RNG
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=552f2f7b96f8fe7aa67d675b90ddde095ec5629a;p=platform%2Fupstream%2Fllvm.git

Process::GetRandomNumber(): fix insecure RNG

This could have generated non-random output under error conditions in release
builds.

llvm-svn: 210065
---

diff --git a/llvm/lib/Support/Windows/Process.inc b/llvm/lib/Support/Windows/Process.inc
index 5e3fd7e..006bd80 100644
--- a/llvm/lib/Support/Windows/Process.inc
+++ b/llvm/lib/Support/Windows/Process.inc
@@ -12,6 +12,7 @@
 //===----------------------------------------------------------------------===//
 
 #include "llvm/Support/Allocator.h"
+#include "llvm/Support/ErrorHandling.h"
 #include <malloc.h>
 
 // The Windows.h header must be after LLVM and standard headers.
@@ -363,12 +364,12 @@ unsigned Process::GetRandomNumber() {
   HCRYPTPROV HCPC;
   if (!::CryptAcquireContextW(&HCPC, NULL, NULL, PROV_RSA_FULL,
                               CRYPT_VERIFYCONTEXT))
-    assert(false && "Could not acquire a cryptographic context");
+    report_fatal_error("Could not acquire a cryptographic context");
 
   ScopedCryptContext CryptoProvider(HCPC);
   unsigned Ret;
   if (!::CryptGenRandom(CryptoProvider, sizeof(Ret),
                         reinterpret_cast<BYTE *>(&Ret)))
-    assert(false && "Could not generate a random number");
+    report_fatal_error("Could not generate a random number");
   return Ret;
 }