From: Richard Biener Date: Wed, 6 Apr 2022 11:46:56 +0000 (+0200) Subject: middle-end/105165 - sorry instead of ICE for _Complex asm goto X-Git-Tag: upstream/12.2.0~657 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=54ed6563d22694aa3e1935f89641a4f696a3a9f7;p=platform%2Fupstream%2Fgcc.git middle-end/105165 - sorry instead of ICE for _Complex asm goto Complex lowering cannot currently deal with asm gotos with _Complex output operands. Emit a sorry instead of ICEing, those should not appear in practice. 2022-04-06 Richard Biener PR middle-end/105165 * tree-complex.cc (expand_complex_asm): Sorry for asm goto _Complex outputs. * gcc.dg/pr105165.c: New testcase. --- diff --git a/gcc/testsuite/gcc.dg/pr105165.c b/gcc/testsuite/gcc.dg/pr105165.c new file mode 100644 index 0000000..055a105 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr105165.c @@ -0,0 +1,13 @@ +/* { dg-do compile } */ +/* { dg-options "-O" } */ + +unsigned int _Complex a0; +unsigned int _Complex +foo (unsigned int _Complex a1, unsigned int _Complex a2) +{ + unsigned int _Complex x; + asm goto ("" : "=r" (x) : : : lab); /* { dg-message "sorry, unimplemented" } */ + a0 = x; + lab: + return x + a1 + a2 + 1; +} diff --git a/gcc/tree-complex.cc b/gcc/tree-complex.cc index 8f03b23..42db96a 100644 --- a/gcc/tree-complex.cc +++ b/gcc/tree-complex.cc @@ -41,6 +41,7 @@ along with GCC; see the file COPYING3. If not see #include "cfgloop.h" #include "cfganal.h" #include "gimple-fold.h" +#include "diagnostic-core.h" /* For each complex ssa name, a lattice value. We're interested in finding @@ -1614,6 +1615,7 @@ expand_complex_asm (gimple_stmt_iterator *gsi) { gasm *stmt = as_a (gsi_stmt (*gsi)); unsigned int i; + bool diagnosed_p = false; for (i = 0; i < gimple_asm_noutputs (stmt); ++i) { @@ -1622,6 +1624,20 @@ expand_complex_asm (gimple_stmt_iterator *gsi) if (TREE_CODE (op) == SSA_NAME && TREE_CODE (TREE_TYPE (op)) == COMPLEX_TYPE) { + if (gimple_asm_nlabels (stmt) > 0) + { + if (!diagnosed_p) + { + sorry_at (gimple_location (stmt), + "% with complex typed outputs"); + diagnosed_p = true; + } + /* Make sure to not ICE later, see PR105165. */ + tree zero = build_zero_cst (TREE_TYPE (TREE_TYPE (op))); + set_component_ssa_name (op, false, zero); + set_component_ssa_name (op, true, zero); + continue; + } tree type = TREE_TYPE (op); tree inner_type = TREE_TYPE (type); tree r = build1 (REALPART_EXPR, inner_type, op);