From: Andy Shevchenko Date: Mon, 3 Dec 2018 09:28:47 +0000 (+0200) Subject: usb: dwc3: trace: add missing break statement to make compiler happy X-Git-Tag: v5.4-rc1~1927^2~16^2~6 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=54d48183d21e03f780053d7129312049cb5dd591;p=platform%2Fkernel%2Flinux-rpi.git usb: dwc3: trace: add missing break statement to make compiler happy The missed break statement in the outer switch makes the code fall through always and thus always same value will be printed. Besides that, compiler warns about missed fall through marker: drivers/usb/dwc3/./trace.h: In function ‘trace_raw_output_dwc3_log_trb’: drivers/usb/dwc3/./trace.h:246:4: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (pcm) { ^~~~~~ Add the missing break statement to work correctly without compilation warnings. Fixes: fa8d965d736b ("usb: dwc3: trace: pretty print high-bandwidth transfers too") Cc: Felipe Balbi Signed-off-by: Andy Shevchenko Signed-off-by: Felipe Balbi --- diff --git a/drivers/usb/dwc3/trace.h b/drivers/usb/dwc3/trace.h index 50fb6f2..e97a005 100644 --- a/drivers/usb/dwc3/trace.h +++ b/drivers/usb/dwc3/trace.h @@ -251,9 +251,11 @@ DECLARE_EVENT_CLASS(dwc3_log_trb, s = "2x "; break; case 3: + default: s = "3x "; break; } + break; default: s = ""; } s; }),