From: Artur Pilipenko <apilipenko@azulsystems.com>
Date: Mon, 8 Aug 2016 14:13:56 +0000 (+0000)
Subject: [LVI] NFC. Rename confusing local NegOffset to Offset
X-Git-Tag: llvmorg-4.0.0-rc1~13061
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=54b50cc1a84b847a01ccda6e31080ecd7d42c2df;p=platform%2Fupstream%2Fllvm.git

[LVI] NFC. Rename confusing local NegOffset to Offset

NegOffset is not necessarily negative

llvm-svn: 278008
---

diff --git a/llvm/lib/Analysis/LazyValueInfo.cpp b/llvm/lib/Analysis/LazyValueInfo.cpp
index 306a1cf..c65c81d 100644
--- a/llvm/lib/Analysis/LazyValueInfo.cpp
+++ b/llvm/lib/Analysis/LazyValueInfo.cpp
@@ -1199,20 +1199,20 @@ bool getValueFromCondition(Value *Val, Value *Cond, LVILatticeVal &Result,
     }
 
     // Recognize the range checking idiom that InstCombine produces.
-    // (X-C1) u< C2 --> [C1, C1+C2)
-    ConstantInt *NegOffset = nullptr;
+    // (X+C1) u< C2 --> [-C1, C2-C1)
+    ConstantInt *Offset = nullptr;
     if (Predicate == ICmpInst::ICMP_ULT)
-      match(LHS, m_Add(m_Specific(Val), m_ConstantInt(NegOffset)));
+      match(LHS, m_Add(m_Specific(Val), m_ConstantInt(Offset)));
 
     ConstantInt *CI = dyn_cast<ConstantInt>(RHS);
-    if (CI && (LHS == Val || NegOffset)) {
+    if (CI && (LHS == Val || Offset)) {
       // Calculate the range of values that are allowed by the comparison
       ConstantRange CmpRange(CI->getValue());
       ConstantRange TrueValues =
           ConstantRange::makeAllowedICmpRegion(Predicate, CmpRange);
 
-      if (NegOffset) // Apply the offset from above.
-        TrueValues = TrueValues.subtract(NegOffset->getValue());
+      if (Offset) // Apply the offset from above.
+        TrueValues = TrueValues.subtract(Offset->getValue());
 
       // If we're interested in the false dest, invert the condition.
       if (!isTrueDest) TrueValues = TrueValues.inverse();