From: Vitalii Vorobiov <vi.vorobiov@samsung.com>
Date: Thu, 30 Jun 2016 09:08:46 +0000 (+0300)
Subject: edje_edit: remove useless pointer grab as it conflicts with elementary combobox
X-Git-Tag: accepted/tizen/common/20160804.174451~30
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=54a9d306cb3388521d3b3558915ad1a2659ac3d1;p=platform%2Fupstream%2Fefl.git

edje_edit: remove useless pointer grab as it conflicts with elementary combobox

Summary:
So currently having an issue related to clip_to function from
EdjeEdit API. I am not sure about how and why combobox use pointer grabbing
(just started to use it) but when setting NULL into clip_to of edje edit it
suddenly block entire screen away from mouse. Only when point is moved out of
window and back, only then it will be able to access widgets again.

Take a look at video and maybe try example to reproduce problem

I am not sure if deleting those functions from edje_edit is actually right
decision. But it will fix the problem of course.

Test Plan: See attached video and examples in attached files

Reviewers: NikaWhite, reutskiy.v.v, Hermet, cedric, raster

Subscribers: jpeg

Differential Revision: https://phab.enlightenment.org/D4081

Change-Id: Icda0649a2aadb0d904d9b2e5884b107e1c4833fb
---

diff --git a/src/lib/edje/edje_edit.c b/src/lib/edje/edje_edit.c
index 0cb81ee..c89d4b4 100644
--- a/src/lib/edje/edje_edit.c
+++ b/src/lib/edje/edje_edit.c
@@ -3695,15 +3695,6 @@ edje_edit_part_clip_to_set(Evas_Object *obj, const char *part, const char *clip_
    /* unset clipping */
    if (!clip_to)
      {
-        if (rp->part->clip_to_id >= 0)
-          {
-             clip = ed->table_parts[rp->part->clip_to_id % ed->table_parts_size];
-
-             evas_object_pointer_mode_set(clip->object,
-                                          EVAS_OBJECT_POINTER_MODE_AUTOGRAB);
-             evas_object_clip_unset(rp->object);
-          }
-
         evas_object_clip_set(rp->object, ed->base->clipper);
         if ((rp->type == EDJE_RP_TYPE_SWALLOW) &&
             (rp->typedata.swallow) && (rp->typedata.swallow->swallowed_object))
@@ -3730,9 +3721,6 @@ edje_edit_part_clip_to_set(Evas_Object *obj, const char *part, const char *clip_
 
    rp->part->clip_to_id = clip->part->id;
 
-   evas_object_pass_events_set(clip->object, 1);
-   evas_object_pointer_mode_set(clip->object, EVAS_OBJECT_POINTER_MODE_NOGRAB);
-   evas_object_clip_set(rp->object, clip->object);
    if ((rp->type == EDJE_RP_TYPE_SWALLOW) &&
        (rp->typedata.swallow) && (rp->typedata.swallow->swallowed_object))
      evas_object_clip_set(rp->typedata.swallow->swallowed_object, clip->object);