From: Mario Six <mario.six@gdsys.cc>
Date: Mon, 15 Jan 2018 10:08:35 +0000 (+0100)
Subject: spi: Fix style violation and improve code
X-Git-Tag: v2018.03-rc1~97^2~17
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=547bcc3d18ddcc107b8aa7ca393830590c27978f;p=platform%2Fkernel%2Fu-boot.git

spi: Fix style violation and improve code

This patch fixes a printf specifier style violation, reduces the scope
of a variable, and turns a void pointer that is used with pointer
arithmetic into a u8 pointer.

Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Jagan Teki <jagan@openedev.com>
---

diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 7d81fbd..dea8dcd 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -12,7 +12,7 @@
 int spi_set_wordlen(struct spi_slave *slave, unsigned int wordlen)
 {
 	if (wordlen == 0 || wordlen > 32) {
-		printf("spi: invalid wordlen %d\n", wordlen);
+		printf("spi: invalid wordlen %u\n", wordlen);
 		return -1;
 	}
 
@@ -24,11 +24,12 @@ int spi_set_wordlen(struct spi_slave *slave, unsigned int wordlen)
 void *spi_do_alloc_slave(int offset, int size, unsigned int bus,
 			 unsigned int cs)
 {
-	struct spi_slave *slave;
-	void *ptr;
+	u8 *ptr;
 
 	ptr = malloc(size);
 	if (ptr) {
+		struct spi_slave *slave;
+
 		memset(ptr, '\0', size);
 		slave = (struct spi_slave *)(ptr + offset);
 		slave->bus = bus;