From: Bowon Ryu Date: Fri, 13 Aug 2021 09:56:35 +0000 (+0900) Subject: [Tizen] Clipboard: fix integer underflow X-Git-Tag: accepted/tizen/unified/20210817.123137^0 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=546d141a0f367154595e05e405ff0462a50d75b5;p=platform%2Fcore%2Fuifw%2Fdali-adaptor.git [Tizen] Clipboard: fix integer underflow GetCount() returns an int, but NumberOfItems() returns an unsigned int. If GetCount() returns a negative number, NumberOfItems() may return an unintended value. There is also the risk of underflow. Change-Id: I8db63963257c616b7a281c14b1c8f2480fbdc91e Signed-off-by: Bowon Ryu --- diff --git a/dali/internal/clipboard/tizen-wayland/clipboard-impl-ecore-wl.cpp b/dali/internal/clipboard/tizen-wayland/clipboard-impl-ecore-wl.cpp index 15aa6a5..b54da7d 100644 --- a/dali/internal/clipboard/tizen-wayland/clipboard-impl-ecore-wl.cpp +++ b/dali/internal/clipboard/tizen-wayland/clipboard-impl-ecore-wl.cpp @@ -307,7 +307,8 @@ void Clipboard::RequestItem() */ unsigned int Clipboard::NumberOfItems() { - return mImpl->GetCount(); + int count = mImpl->GetCount(); + return (count < 0 ? 0 : count); } void Clipboard::ShowClipboard()