From: Razvan Stefanescu Date: Fri, 5 Jul 2019 14:27:11 +0000 (+0300) Subject: staging: fsl-dpaa2/ethsw: Fix setting port learning/flooding flags X-Git-Tag: v5.4-rc1~134^2~325 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=543ba01d99cc6b4007c1f9a475c1d572c46a5543;p=platform%2Fkernel%2Flinux-rpi.git staging: fsl-dpaa2/ethsw: Fix setting port learning/flooding flags ethsw_set_learning()/ethsw_set_flood() use flags parameter as an enable/disable (1/0) indicator. Previous usage sent incorrect values. Signed-off-by: Razvan Stefanescu Signed-off-by: Ioana Ciornei Link: https://lore.kernel.org/r/1562336836-17119-2-git-send-email-ioana.ciornei@nxp.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c index f73edaf..8747007 100644 --- a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c +++ b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c @@ -673,11 +673,12 @@ static int port_attr_br_flags_set(struct net_device *netdev, return 0; /* Learning is enabled per switch */ - err = ethsw_set_learning(port_priv->ethsw_data, flags & BR_LEARNING); + err = ethsw_set_learning(port_priv->ethsw_data, + !!(flags & BR_LEARNING)); if (err) goto exit; - err = ethsw_port_set_flood(port_priv, flags & BR_FLOOD); + err = ethsw_port_set_flood(port_priv, !!(flags & BR_FLOOD)); exit: return err;