From: Piotr Byszewski Date: Thu, 17 Jan 2019 12:37:07 +0000 (+0100) Subject: Fix validation failure in float_controls X-Git-Tag: upstream/1.3.5~2185^2^2~18 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=53cfa7b2eceac6b386e4ca5aa36b992c533f37c5;p=platform%2Fupstream%2FVK-GL-CTS.git Fix validation failure in float_controls Half of float_controls tests read operation arguments from SSBO (other half generates them in the code). Whent vertex stage is tested this SSBO must be decorated as NonWritable. This change resolves this issue by applying NonWritable decoration to input SSBO for all tested stages. Operation output is always saved in fragment stage and to separate SSBO. Components: Vulkan VK-GL-CTS issue: 1543 Affects: dEQP-VK.spirv_assembly.instruction.compute.float_controls.* dEQP-VK.spirv_assembly.instruction.graphics.float_controls.* Change-Id: Iaed891d7b45b2a5f02ce1443dc13a40e24fa2086 --- diff --git a/external/vulkancts/modules/vulkan/spirv_assembly/vktSpvAsmFloatControlsTests.cpp b/external/vulkancts/modules/vulkan/spirv_assembly/vktSpvAsmFloatControlsTests.cpp index aef15a4..599c151 100644 --- a/external/vulkancts/modules/vulkan/spirv_assembly/vktSpvAsmFloatControlsTests.cpp +++ b/external/vulkancts/modules/vulkan/spirv_assembly/vktSpvAsmFloatControlsTests.cpp @@ -668,7 +668,8 @@ void TypeSnippetsBase::updateSpirvSnippets() "OpMemberDecorate %SSBO_in 0 Offset 0\n" "OpDecorate %SSBO_in BufferBlock\n" "OpDecorate %ssbo_in DescriptorSet 0\n" - "OpDecorate %ssbo_in Binding 0\n"; + "OpDecorate %ssbo_in Binding 0\n" + "OpDecorate %ssbo_in NonWritable\n"; const string inputDefinitionsTemplate = "%SSBO_in = OpTypeStruct %type_float_arr_2\n"