From: Bartosz Golaszewski Date: Thu, 28 Jun 2018 14:42:20 +0000 (+0100) Subject: ARM: 8778/1: clkdev: don't call __of_clk_get_by_name() unnecessarily from clk_get() X-Git-Tag: v4.19~459^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=53ccb22b8d4a9293cf4249f3b526892810038fd3;p=platform%2Fkernel%2Flinux-rpi.git ARM: 8778/1: clkdev: don't call __of_clk_get_by_name() unnecessarily from clk_get() The way this function is implemented caused some confusion when converting the TI DaVinci platform to using the common clock framework. Current kernel supports booting DaVinci boards both in device tree as well as legacy, board-file mode. In the latter, we always end up calling clk_get_sys() as of_node is NULL and __of_clk_get_by_name() returns -ENOENT. It was not obvious at first glance how clk_get(dev, NULL) will work in board-file mode since we always call __of_clk_get_by_name(). Let's make it clearer by checking if of_node is NULL and skipping right to clk_get_sys(). Cc: Sekhar Nori Cc: Kevin Hilman Cc: David Lechner Reviewed-by: David Lechner Reviewed-by: Sekhar Nori Signed-off-by: Bartosz Golaszewski Signed-off-by: Russell King --- diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c index 02fcee2..9ab3db8 100644 --- a/drivers/clk/clkdev.c +++ b/drivers/clk/clkdev.c @@ -196,7 +196,7 @@ struct clk *clk_get(struct device *dev, const char *con_id) const char *dev_id = dev ? dev_name(dev) : NULL; struct clk *clk; - if (dev) { + if (dev && dev->of_node) { clk = __of_clk_get_by_name(dev->of_node, dev_id, con_id); if (!IS_ERR(clk) || PTR_ERR(clk) == -EPROBE_DEFER) return clk;