From: amy.shih Date: Wed, 18 Sep 2019 08:48:00 +0000 (+0800) Subject: hwmon: (nct7904) Fix the incorrect value of vsen_mask in nct7904_data struct X-Git-Tag: v5.4-rc3~2^2~5 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=539ad001d1557731cb38d4a9d0e8e16244b2d913;p=platform%2Fkernel%2Flinux-rpi.git hwmon: (nct7904) Fix the incorrect value of vsen_mask in nct7904_data struct Voltage sensors overlap with external temperature sensors. Detect the multi-function of voltage, thermal diode and thermistor from register VT_ADC_MD_REG to set value of vsen_mask in nct7904_data struct. Signed-off-by: amy.shih Link: https://lore.kernel.org/r/20190918084801.9859-1-Amy.Shih@advantech.com.tw Signed-off-by: Guenter Roeck --- diff --git a/drivers/hwmon/nct7904.c b/drivers/hwmon/nct7904.c index 95b447cf..f62dd18 100644 --- a/drivers/hwmon/nct7904.c +++ b/drivers/hwmon/nct7904.c @@ -915,12 +915,15 @@ static int nct7904_probe(struct i2c_client *client, data->temp_mode = 0; for (i = 0; i < 4; i++) { - val = (ret & (0x03 << i)) >> (i * 2); + val = (ret >> (i * 2)) & 0x03; bit = (1 << i); - if (val == 0) + if (val == 0) { data->tcpu_mask &= ~bit; - else if (val == 0x1 || val == 0x2) - data->temp_mode |= bit; + } else { + if (val == 0x1 || val == 0x2) + data->temp_mode |= bit; + data->vsen_mask &= ~(0x06 << (i * 2)); + } } /* PECI */