From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: Thu, 6 Jul 2023 09:38:25 +0000 (+0200)
Subject: can: gs_usb: gs_destroy_candev(): remove not needed usb_kill_anchored_urbs()
X-Git-Tag: v6.6.7~2079^2~308^2~1^2~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5391e0cbae02cdf2df501f104c2c7dc0bceeec3d;p=platform%2Fkernel%2Flinux-starfive.git

can: gs_usb: gs_destroy_candev(): remove not needed usb_kill_anchored_urbs()

In gs_destroy_candev(), the netdev is unregistered first, then all
anchored TX URBs (dev->tx_submitted) are disposed with
usb_kill_anchored_urbs().

The call to usb_kill_anchored_urbs() is not needed, as
unregister_candev() calls gs_can_close(), which already disposes the
TX URBS.

Remove not needed call to usb_kill_anchored_urbs() from
gs_destroy_candev().

Link: https://lore.kernel.org/all/20230718-gs_usb-cleanups-v1-10-c3b9154ec605@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---

diff --git a/drivers/net/can/usb/gs_usb.c b/drivers/net/can/usb/gs_usb.c
index 7718f6a4..5a0017b 100644
--- a/drivers/net/can/usb/gs_usb.c
+++ b/drivers/net/can/usb/gs_usb.c
@@ -1356,7 +1356,6 @@ out_free_candev:
 static void gs_destroy_candev(struct gs_can *dev)
 {
 	unregister_candev(dev->netdev);
-	usb_kill_anchored_urbs(&dev->tx_submitted);
 	free_candev(dev->netdev);
 }