From: Stefan Roese Date: Wed, 21 Dec 2022 09:18:49 +0000 (+0100) Subject: timer: orion-timer: Fix problem with early static variable X-Git-Tag: v2023.07~217^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5387b093cb7914b3c0404da928fa4bafdffac291;p=platform%2Fkernel%2Fu-boot.git timer: orion-timer: Fix problem with early static variable We've noticed that at least one Kirkwood board (Pogo v4) has problems with the new orion DM timer implementation. Debugging revealed that this issue is related with the static variable "early_init_done" which does not work correctly before relocation in all cases. This patch removes this static variable and replaces it's functionality via a function that detects if the timer is already initialized. Signed-off-by: Stefan Roese Cc: Pali Rohár Cc: Michael Walle Cc: Tony Dinh Tested-by: Tony Dinh --- diff --git a/drivers/timer/orion-timer.c b/drivers/timer/orion-timer.c index d0eab3c..6804bf0 100644 --- a/drivers/timer/orion-timer.c +++ b/drivers/timer/orion-timer.c @@ -23,15 +23,19 @@ struct orion_timer_priv { #define MVEBU_TIMER_FIXED_RATE_25MHZ 25000000 -static bool early_init_done __section(".data") = false; +static bool early_init_done(void *base) +{ + if (readl(base + TIMER_CTRL) & TIMER0_EN) + return true; + return false; +} /* Common functions for early (boot) and DM based timer */ static void orion_timer_init(void *base, enum input_clock_type type) { /* Only init the timer once */ - if (early_init_done) + if (early_init_done(base)) return; - early_init_done = true; writel(~0, base + TIMER0_VAL); writel(~0, base + TIMER0_RELOAD);