From: Doyoun Kang Date: Mon, 20 Aug 2018 09:59:04 +0000 (+0900) Subject: e_client: check mapped condition before calling evas_object_show in e_client_uniconify X-Git-Tag: submit/tizen/20180828.083306~8 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=532f8da27eb82be33157b5c46fc17f72a96b6876;p=platform%2Fupstream%2Fenlightenment.git e_client: check mapped condition before calling evas_object_show in e_client_uniconify The window which had unmapped and iconified by client didn't show when it called show at the first time. We fixed this problem. Also, this patch can resolve a bug resolved by below patch. - e_client: check mapped condition when e_client_uniconify - commit id: 632261617acada66b019931de981eed332f50f04 Change-Id: Ibc5b84ee047002e5d6ee9bfd7c4a4284ffab8174 --- diff --git a/src/bin/e_client.c b/src/bin/e_client.c index 4dc562898e..f4bc29a19e 100644 --- a/src/bin/e_client.c +++ b/src/bin/e_client.c @@ -5485,7 +5485,6 @@ e_client_uniconify(E_Client *ec) if (!ec->zone) return; if (ec->shading || (!ec->iconic)) return; - if ((!ec->comp_data) || (!ec->comp_data->mapped)) return; TRACE_DS_BEGIN(CLIENT:UNICONIFY); @@ -5519,8 +5518,15 @@ e_client_uniconify(E_Client *ec) if (ec->pixmap && e_pixmap_usable_get(ec->pixmap)) { - ELOGF("TZVIS", "UNICONIFY|object show", ec->pixmap, ec); - evas_object_show(ec->frame); + if (ec->comp_data && ec->comp_data->mapped) + { + ELOGF("TZVIS", "UNICONIFY|object show", ec->pixmap, ec); + evas_object_show(ec->frame); + } + else + { + ELOGF("TZVIS", "UNICONIFY|object no show. currently unmapped", ec->pixmap, ec); + } } e_client_comp_hidden_set(ec, 0);