From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Wed, 19 Aug 2020 11:02:01 +0000 (+0200)
Subject: r8169: use napi_complete_done return value
X-Git-Tag: v5.15~2655^2~481^2~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=52dbe8465e5b85263a4c28a48bc902e8c50b2f1b;p=platform%2Fkernel%2Flinux-starfive.git

r8169: use napi_complete_done return value

Consider the return value of napi_complete_done(), this allows users to
use the gro_flush_timeout sysfs attribute as an alternative to classic
interrupt coalescing.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index d1da92a..dbc324c 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -4596,10 +4596,8 @@ static int rtl8169_poll(struct napi_struct *napi, int budget)
 
 	rtl_tx(dev, tp, budget);
 
-	if (work_done < budget) {
-		napi_complete_done(napi, work_done);
+	if (work_done < budget && napi_complete_done(napi, work_done))
 		rtl_irq_enable(tp);
-	}
 
 	return work_done;
 }