From: Krzysztof Kozlowski Date: Thu, 15 Jun 2017 16:33:15 +0000 (+0200) Subject: pinctrl: samsung: Use unsigned int for number of controller IO mem resources X-Git-Tag: v5.15~10528^2~45^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=52d0ed009cfba83b3cc869380497361f699a4545;p=platform%2Fkernel%2Flinux-starfive.git pinctrl: samsung: Use unsigned int for number of controller IO mem resources Number of IO memory resources cannot be negative obviously and the driver depends silently on this (by iterating from 0 to nr_ext_resources+1). Make this requirement explicit. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Sylwester Nawrocki --- diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c index 1f73dd2..6efb428 100644 --- a/drivers/pinctrl/samsung/pinctrl-samsung.c +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c @@ -960,7 +960,7 @@ samsung_pinctrl_get_soc_data(struct samsung_pinctrl_drv_data *d, struct samsung_pin_bank *bank; struct resource *res; void __iomem *virt_base[SAMSUNG_PINCTRL_NUM_RESOURCES]; - int i; + unsigned int i; id = of_alias_get_id(node, "pinctrl"); if (id < 0) { diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.h b/drivers/pinctrl/samsung/pinctrl-samsung.h index 15b26c7..49a05f4 100644 --- a/drivers/pinctrl/samsung/pinctrl-samsung.h +++ b/drivers/pinctrl/samsung/pinctrl-samsung.h @@ -231,7 +231,7 @@ struct samsung_retention_data { struct samsung_pin_ctrl { const struct samsung_pin_bank_data *pin_banks; u32 nr_banks; - int nr_ext_resources; + unsigned int nr_ext_resources; const struct samsung_retention_data *retention_data; int (*eint_gpio_init)(struct samsung_pinctrl_drv_data *);