From: SangYong Park <sy302.park@samsung.com>
Date: Thu, 11 Jul 2019 22:00:22 +0000 (+0900)
Subject: Create new window with option of parent window
X-Git-Tag: submit/tizen/20190814.020427~6
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=52a46570708294d2fc32d8ed08c7ac9a24e244b5;p=platform%2Fframework%2Fweb%2Fwrtjs.git

Create new window with option of parent window

Currently new window is created with electron's default option.
Some javascript contents has conflict with node.js. so, apply
parent window's option when new window is created.
(webtct tct-ui01-wrt-tests failed because of this issue.)

Change-Id: I148879d4b74e00abb037176a315de5774193e076
Signed-off-by: SangYong Park <sy302.park@samsung.com>
---

diff --git a/wrt_app/browser/wrt_window.js b/wrt_app/browser/wrt_window.js
index e3a59773..573ad4f5 100644
--- a/wrt_app/browser/wrt_window.js
+++ b/wrt_app/browser/wrt_window.js
@@ -27,10 +27,11 @@ WRTWindow.prototype._init = function () {
   let self = this
   this.webContents.on('new-window', (event, url, frameName, disposition, options) => {
     event.preventDefault()
-    let parentOptions = self.browserWindowOptions || {}
-    parentOptions.webContents = options.webContents || WRTWebContents()
-    const win = new WRTWindow(parentOptions)
-    event.newGuest = win
+    if (!options.webContents || options.webContents === self) {
+      options.webContents = WRTWebContents()
+      options.webContents.loadURL(url)
+    }
+    event.newGuest = new WRTWindow(options)
   })
 }